-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple fuzz test for jsoncpp. #610
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,8 @@ | |
ADD_EXECUTABLE( jsoncpp_test | ||
jsontest.cpp | ||
jsontest.h | ||
fuzz.cpp | ||
fuzz.h | ||
main.cpp | ||
) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// Copyright 2007-2010 The JsonCpp Authors | ||
// Distributed under MIT license, or public domain if desired and | ||
// recognized in your jurisdiction. | ||
// See file LICENSE for detail or copy at http://jsoncpp.sourceforge.net/LICENSE | ||
|
||
#include "fuzz.h" | ||
|
||
#include <json/config.h> | ||
#include <json/json.h> | ||
#include <memory> | ||
#include <string> | ||
#include <stdint.h> | ||
|
||
namespace { | ||
// https://en.wikipedia.org/wiki/Jenkins_hash_function#one-at-a-time | ||
uint32_t JenkinsOneAtATimeHash(const uint8_t* data, size_t size) { | ||
uint32_t hash = 0; | ||
for (size_t i = 0; i < size; i++) { | ||
hash += data[i]; | ||
hash += hash << 10; | ||
hash ^= hash >> 6; | ||
} | ||
hash += hash << 3; | ||
hash ^= hash >> 11; | ||
hash += hash << 15; | ||
return hash; | ||
} | ||
} // namespace | ||
|
||
namespace Json { | ||
class Exception; | ||
} | ||
|
||
extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | ||
Json::CharReaderBuilder builder; | ||
|
||
uint32_t hash_settings = JenkinsOneAtATimeHash(data, size); | ||
builder.settings_["failIfExtra"] = hash_settings & (1 << 0); | ||
builder.settings_["allowComments_"] = hash_settings & (1 << 1); | ||
builder.settings_["strictRoot_"] = hash_settings & (1 << 2); | ||
builder.settings_["allowDroppedNullPlaceholders_"] = hash_settings & (1 << 3); | ||
builder.settings_["allowNumericKeys_"] = hash_settings & (1 << 4); | ||
builder.settings_["allowSingleQuotes_"] = hash_settings & (1 << 5); | ||
builder.settings_["failIfExtra_"] = hash_settings & (1 << 6); | ||
builder.settings_["rejectDupKeys_"] = hash_settings & (1 << 7); | ||
builder.settings_["allowSpecialFloats_"] = hash_settings & (1 << 8); | ||
|
||
std::unique_ptr<Json::CharReader> reader(builder.newCharReader()); | ||
|
||
Json::Value root; | ||
const char* data_str = reinterpret_cast<const char*>(data); | ||
try { | ||
reader->parse(data_str, data_str + size, &root, nullptr); | ||
} catch (Json::Exception const&) {} | ||
// Whether it succeeded or not doesn't matter. | ||
return 0; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Copyright 2007-2010 The JsonCpp Authors | ||
// Distributed under MIT license, or public domain if desired and | ||
// recognized in your jurisdiction. | ||
// See file LICENSE for detail or copy at http://jsoncpp.sourceforge.net/LICENSE | ||
|
||
#ifndef FUZZ_H_INCLUDED | ||
#define FUZZ_H_INCLUDED | ||
|
||
#include <stddef.h> | ||
#include <stdint.h> | ||
|
||
extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size); | ||
|
||
#endif // ifndef FUZZ_H_INCLUDED |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than hashing the input, it's simpler to just use the first byte or two for configuring options. We can early return 0 if size < REQUIRED_BYTES_FOR_CONFIG, and the fuzzer will figure out not to follow this edge pretty quickly.