Skip to content

Add WideString test for Issue #756 #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

BillyDonahue
Copy link
Contributor

Testing shows no problems on the jsoncpp side.

@cdunn2001
Copy link
Contributor

Hmm. This fails in AppVeyor for VS2012. Worth addressing?

@hjmjohnson
Copy link
Contributor

@BillyDonahue Is this worth rebase on the current master branch?

@BillyGoto
Copy link

BillyGoto commented Jan 18, 2019 via email

@baylesj
Copy link
Contributor

baylesj commented Jun 24, 2019

Is this still relevant? I would like to merge or close all the outstanding PRs... especially the old ones like this one.

@baylesj
Copy link
Contributor

baylesj commented Jun 25, 2019

Looked into this, VS 2012 and 2013 don't support the u8 operator. Considering it's now 2019, I'd be open to rolling the dependency to VS 2015 or something more modern, which would resolve this issue.

@baylesj
Copy link
Contributor

baylesj commented Jun 25, 2019

I'm going to roll our Travis and Appveyor dependencies, then hopefully this should just be plug and play.

#955

@baylesj
Copy link
Contributor

baylesj commented Jun 25, 2019

Running tests in a separate PR since I couldn't figure out how to kick Travis here:

#956

If they pass, I'll merge this and feel good about it.

@baylesj baylesj added this to the 2.0.0 milestone Jun 25, 2019
@baylesj
Copy link
Contributor

baylesj commented Jun 25, 2019

All checks passed. Merging!

@baylesj baylesj merged commit dd6921f into open-source-parsers:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants