ci: bump qemu to v8 #158
ci: bump qemu to v8 #158
Conversation
WalkthroughThis pull request updates GitHub Actions workflow configurations for building images and packages. The changes focus on upgrading QEMU setup actions and specifying a precise QEMU binary format image version ( Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* ci: capture exit code properly * chore: simplify exit * style: fix whitespace
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
tools/development/helpers/check-format-cpp.sh(1 hunks)tools/development/helpers/check-format-python.sh(1 hunks)tools/development/helpers/format-cpp.sh(1 hunks)tools/development/helpers/format-python.sh(1 hunks)tools/development/helpers/test-python.sh(1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
tools/development/helpers/test-python.sh
[error] 10-10: Double quote array expansions to avoid re-splitting elements.
(SC2068)
tools/development/helpers/check-format-cpp.sh
[warning] 9-9: Quote this to prevent word splitting.
(SC2046)
tools/development/helpers/format-cpp.sh
[warning] 9-9: Quote this to prevent word splitting.
(SC2046)
🔇 Additional comments (5)
tools/development/helpers/format-python.sh (1)
9-10: LGTM! Good error handling addition.Adding
|| exit 1ensures the script fails immediately if the formatting command fails, which is a good practice for CI/CD pipelines.tools/development/helpers/check-format-python.sh (1)
9-10: LGTM! Consistent error handling.Adding
|| exit 1ensures consistent error handling with other scripts and proper pipeline failure reporting.tools/development/helpers/test-python.sh (1)
10-11: LGTM! Good error handling for tests.Adding
|| exit 1ensures test failures are properly reported in the pipeline.🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 10-10: Double quote array expansions to avoid re-splitting elements.
(SC2068)
tools/development/helpers/format-cpp.sh (1)
9-10: LGTM! Good error handling for C++ formatting.Adding
|| exit 1ensures formatting failures are properly reported in the pipeline.🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 9-9: Quote this to prevent word splitting.
(SC2046)
tools/development/helpers/check-format-cpp.sh (1)
9-10: LGTM! Good error handling for C++ format checking.Adding
|| exit 1ensures format check failures are properly reported in the pipeline.🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 9-9: Quote this to prevent word splitting.
(SC2046)
This reverts commit 4cdb71f.
Pipeline jobs using QEMU to compile code to arm64 have been intermittently failing for the past few days. This has been reported here and here. Following the suggestion in the latter thread, we seem to be able to fix it by manually using the QEMU v8 image (the GH action uses the
latesttag, which hasn't been updated on dockerhub in 2 years)Unsure of why this has suddenly started happening now, but we'll soon be able to avoid using QEMU altogether once we update the CI to use arm-native runners
also bumps the
setup-qemu-actionto v3 across the board.