Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] switch of enable/disable short-term schedule #56

Open
L-M-Sherlock opened this issue Aug 27, 2024 · 12 comments
Open

[TODO] switch of enable/disable short-term schedule #56

L-M-Sherlock opened this issue Aug 27, 2024 · 12 comments
Labels
enhancement New feature or request

Comments

@L-M-Sherlock
Copy link
Member

The implementation of ts-fsrs:

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Aug 27, 2024
@joshdavham
Copy link
Member

Can I get some more context on this? I have a lot of trouble reading typescript.

@L-M-Sherlock
Copy link
Member Author

I also implemented the Golang version:

@joshdavham
Copy link
Member

Code aside, at a high level, what is this new long / short term scheduler thing? Is it described anywhere else other than in source code?

@L-M-Sherlock
Copy link
Member Author

@ishiko732 , do we have the diagram?

@ishiko732
Copy link
Member

do we have the diagram?

Currently, there isn’t one available; it might take some time to create a diagram.

@ishiko732
Copy link
Member

I have updated the diagram, and you can download the original file from the following link: https://drive.google.com/file/d/1oigP0bheX9cXOO9baqwDTzAZ9IWvpCio/view?usp=sharing

@ishiko732
Copy link
Member

Long-term Scheduler WorkFlow:
ts-fsrs-workflow-Long-term Scheduler WorkFlow drawio

Enable_short_term:
ts-fsrs-workflow-enable_short_term drawio

@ishiko732
Copy link
Member

Short-term Scheduler:
ts-fsrs-workflow-Short-term Scheduler Sequence  drawio

Long-term Scheduler:
ts-fsrs-workflow-Long-term Scheduler Sequence drawio

@domino14
Copy link

And what does it mean? I thought the interval times were inherent to the algorithm. Do the different schedulers have different constants?

@joshdavham
Copy link
Member

@domino14 py-fsrs currently only has one scheduler. You can take a look at ALGORITHM.md for details.

As for the new long term scheduler option, which isn't implemented yet, there will be no learning/relearning state for the cards and furthermore, rating a card again, may not necessarily cause it to be due again in the same day, as the interval may be longer (e.g., 2 days, 6 days). The long term scheduler will be sorta be a more 'natural' version of fsrs with less rules.

@joshdavham joshdavham pinned this issue Sep 24, 2024
@domino14
Copy link

domino14 commented Sep 24, 2024 via email

@joshdavham
Copy link
Member

joshdavham commented Sep 24, 2024

@domino14 I can't say for sure. It'd be best to ask that question in the go-fsrs repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants