-
Notifications
You must be signed in to change notification settings - Fork 89
fix: wait for HTTP server serve() termination #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wait for HTTP server serve() termination #348
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 78.35% 78.46% +0.11%
==========================================
Files 25 25
Lines 2402 2419 +17
==========================================
+ Hits 1882 1898 +16
- Misses 412 413 +1
Partials 108 108 ☔ View full report in Codecov by Sentry. |
Please update doc-comment of OpAMPServer.Stop() to explain that it waits until the server socket is released. |
looks like there is an unrelated flaky test on the examples: |
related data race issue #256 |
372361f
to
4e4986f
Compare
@tigrannajaryan The race condition test is now green after merging main. There are some changes on the files related to formatting which I think it would be better to tackle in a separate PR: #356 |
Excellent! Let's get #356 merged and then we will merge this one. Thank you for your patience and for going the extra mile. |
1d7b54f
to
cb710d3
Compare
Thanks for your review! Rebased 👍 |
Fixes #347