Create simple Supervisor example #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 78.07% 78.07%
=======================================
Files 22 22
Lines 1733 1733
=======================================
Hits 1353 1353
Misses 285 285
Partials 95 95 Continue to review full report at Codecov.
|
tigrannajaryan
force-pushed
the
feature/tigran/begin-supervisor
branch
from
b438fb1 to
feedb95
Compare
|
@andykellr @pmm-sumo please review. |
pmm-sumo
reviewed
May 25, 2022
tigrannajaryan
force-pushed
the
feature/tigran/begin-supervisor
branch
from
feedb95 to
42220b9
Compare
- The Supervisor can manage OpenTelemetry Collector. - Demonstrates basic features: applying config, configuring Collector to collect its own metrics. TODO: - Find a way to fetch Collector version instead of hard-coding it. - Set instance id in the Collector config file to make sure OpAMP and Collector metrics use the same instance id. (Related open issue open-telemetry/opentelemetry-collector#5398) - Re-think callbacks to avoid unnecessary restarts (See open-telemetry#77) - Add a way for Supervisor to understand why the Collector process exited unexpectedly.
tigrannajaryan
force-pushed
the
feature/tigran/begin-supervisor
branch
from
42220b9 to
b971ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
metrics use the same instance id.
(Related open issue Allow specifying Collector's own Resource in the config opentelemetry-collector#5398)
(See Rethink OpAMP Client callbacks #77)