Fix Markdown link checking action #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould now fail Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
tpaschalis
commented
Jul 1, 2024
specification.md
Outdated
| @@ -3144,14 +3144,14 @@ reduce the number of connections to the Server when a very large number | |||
|
|
|||
| ### Configuration Management | |||
|
|
|||
| * [Uber Flipr](https://eng.uber.com/flipr/) | |||
| * [Uber Flipr](https://web.archive.org/web/20240223111552/https://www.uber.com/blog/flipr/) | |||
There was a problem hiding this comment.
The actual link is now https://www.uber.com/blog/flipr/, but hitting the link with cURL results in 406 Not Acceptable so I opted for the web.archive.org link.
There was a problem hiding this comment.
Given that https://www.uber.com/blog/flipr exists, I'd vote to have an ignore pattern for this one.
tpaschalis
commented
Jul 1, 2024
| * Facebook's | ||
| [Holistic Configuration Management](https://research.facebook.com/file/877841159827226/holistic-configuration-management-at-facebook.pdf) | ||
| (push) | ||
|
|
||
| ### Security and Certificate Management | ||
|
|
||
| * [mTLS in Go](https://kofo.dev/how-to-mtls-in-golang) | ||
| * [mTLS in Go](https://web.archive.org/web/20240223142649/https://kofo.dev/how-to-mtls-in-golang) |
There was a problem hiding this comment.
This person's website has gone offline so I replaced this with the link from the Wayback Machine.
chalin
reviewed
Jul 1, 2024
specification.md
Outdated
| @@ -3144,14 +3144,14 @@ reduce the number of connections to the Server when a very large number | |||
|
|
|||
| ### Configuration Management | |||
|
|
|||
| * [Uber Flipr](https://eng.uber.com/flipr/) | |||
| * [Uber Flipr](https://web.archive.org/web/20240223111552/https://www.uber.com/blog/flipr/) | |||
There was a problem hiding this comment.
Given that https://www.uber.com/blog/flipr exists, I'd vote to have an ignore pattern for this one.
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
tigrannajaryan
approved these changes
Jul 2, 2024
|
Thank you @tpaschalis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170