This repository has been archived by the owner on Oct 29, 2021. It is now read-only.
Generate custom service code for Windows #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loomis-relativity
requested review from
a team,
Aneurysm9 and
jpkrohling
and removed request for
a team
jpkrohling
previously approved these changes
Oct 5, 2021
|
@loomis-relativity, sorry for the delay in reviewing. Would you be able to resolve the conflicts? Once this is done and the tests are passing (I just triggered them), I'll merge this. Thanks for the PR! |
@jpkrohling Yes, I'll resolve the conflict and push the update. I'll also ping our legal department to ensure that the EasyCLA flags have been set correctly. |
|
@jpkrohling Legal finally got the flags set up for EasyCLA. Please review and let me know if any changes need to be made. |
jpkrohling
approved these changes
Oct 13, 2021
jpkrohling
changed the title
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request pulls in the latest versions of the
main*.gofiles so that running the generated collector as a Windows service works (fixes #73). The code has been pulled from upstream tag 0.35.0; there are further minor changes in 0.36.0 that are not yet compatible with the current code base.All of the current unit tests pass, and the change has been checked manually with a Windows service deployment.