Apply suggestions from code review

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
open-telemetry · Jul 14, 2023 · 28d3354 · 28d3354
1 parent 717166f
commit 28d3354
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/receiver/k8sclusterreceiver/internal/cronjob/cronjobs.go b/receiver/k8sclusterreceiver/internal/cronjob/cronjobs.go
@@ -30,8 +30,12 @@ func GetMetrics(set receiver.CreateSettings, cj *batchv1.CronJob) pmetric.Metric
 
 	mbphase.RecordK8sCronjobActiveJobsDataPoint(ts, int64(len(cj.Status.Active)))
 
-	metrics := mbphase.Emit(imetadataphase.WithK8sNamespaceName(cj.Namespace), imetadataphase.WithK8sCronjobUID(string(cj.UID)), imetadataphase.WithK8sCronjobName(cj.Name), imetadataphase.WithOpencensusResourcetype("k8s"))
-	return metrics
+	return mbphase.Emit(
+		imetadataphase.WithK8sNamespaceName(cj.Namespace),
+		imetadataphase.WithK8sCronjobUID(string(cj.UID)),
+		imetadataphase.WithK8sCronjobName(cj.Name),
+		imetadataphase.WithOpencensusResourcetype("k8s"),
+	)
 }
 
 func GetMetricsBeta(set receiver.CreateSettings, cj *batchv1beta1.CronJob) pmetric.Metrics {
@@ -40,8 +44,13 @@ func GetMetricsBeta(set receiver.CreateSettings, cj *batchv1beta1.CronJob) pmetr
 
 	mbphase.RecordK8sCronjobActiveJobsDataPoint(ts, int64(len(cj.Status.Active)))
 
-	metrics := mbphase.Emit(imetadataphase.WithK8sNamespaceName(cj.Namespace), imetadataphase.WithK8sCronjobUID(string(cj.UID)), imetadataphase.WithK8sCronjobName(cj.Name), imetadataphase.WithOpencensusResourcetype("k8s"))
-	return metrics
+	return mbphase.Emit(
+		imetadataphase.WithK8sNamespaceName(cj.Namespace),
+		imetadataphase.WithK8sCronjobUID(string(cj.UID)),
+		imetadataphase.WithK8sCronjobName(cj.Name),
+		imetadataphase.WithOpencensusResourcetype("k8s"),
+	)
+
 }
 
 func GetMetadata(cj *batchv1.CronJob) map[experimentalmetricmetadata.ResourceID]*metadata.KubernetesMetadata {