[chore] fix lint errors (#34724)

Fix linter failures found in #34664, namely: no need to check whether a slice is nil if you already check its length.
open-telemetry · Aug 16, 2024 · 8fb6b92 · 8fb6b92
1 parent eaa0888
commit 8fb6b92
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/exporter/signalfxexporter/internal/apm/correlations/client_test.go b/exporter/signalfxexporter/internal/apm/correlations/client_test.go
@@ -63,7 +63,7 @@ func makeHandler(t *testing.T, corCh chan<- *request, forcedRespCode *atomic.Val
 		switch r.Method {
 		case http.MethodGet:
 			match := getPathRegexp.FindStringSubmatch(r.URL.Path)
-			if match == nil || len(match) < 3 {
+			if len(match) < 3 {
 				rw.WriteHeader(404)
 				return
 			}
@@ -78,7 +78,7 @@ func makeHandler(t *testing.T, corCh chan<- *request, forcedRespCode *atomic.Val
 			return
 		case http.MethodPut:
 			match := putPathRegexp.FindStringSubmatch(r.URL.Path)
-			if match == nil || len(match) < 4 {
+			if len(match) < 4 {
 				rw.WriteHeader(404)
 				return
 			}
@@ -100,7 +100,7 @@ func makeHandler(t *testing.T, corCh chan<- *request, forcedRespCode *atomic.Val
 
 		case http.MethodDelete:
 			match := deletePathRegexp.FindStringSubmatch(r.URL.Path)
-			if match == nil || len(match) < 5 {
+			if len(match) < 5 {
 				rw.WriteHeader(404)
 				return
 			}

diff --git a/extension/headerssetterextension/config.go b/extension/headerssetterextension/config.go
@@ -45,7 +45,7 @@ const (
 
 // Validate checks if the extension configuration is valid
 func (cfg *Config) Validate() error {
-	if cfg.HeadersConfig == nil || len(cfg.HeadersConfig) == 0 {
+	if len(cfg.HeadersConfig) == 0 {
 		return errMissingHeadersConfig
 	}
 	for _, header := range cfg.HeadersConfig {

diff --git a/pkg/stanza/adapter/converter.go b/pkg/stanza/adapter/converter.go
@@ -276,7 +276,7 @@ func convertInto(ent *entry.Entry, dest plog.LogRecord) {
 		copy(buffer[0:8], ent.SpanID)
 		dest.SetSpanID(buffer)
 	}
-	if ent.TraceFlags != nil && len(ent.TraceFlags) > 0 {
+	if len(ent.TraceFlags) > 0 {
 		// The 8 least significant bits are the trace flags as defined in W3C Trace
 		// Context specification. Don't override the 24 reserved bits.
 		flags := uint32(ent.TraceFlags[0])

diff --git a/pkg/stanza/operator/transformer/retain/config.go b/pkg/stanza/operator/transformer/retain/config.go
@@ -44,7 +44,7 @@ func (c Config) Build(set component.TelemetrySettings) (operator.Operator, error
 	if err != nil {
 		return nil, err
 	}
-	if c.Fields == nil || len(c.Fields) == 0 {
+	if len(c.Fields) == 0 {
 		return nil, fmt.Errorf("retain: 'fields' is empty")
 	}
 

diff --git a/receiver/httpcheckreceiver/scraper.go b/receiver/httpcheckreceiver/scraper.go
@@ -46,7 +46,7 @@ func (h *httpcheckScraper) start(ctx context.Context, host component.Host) (err
 
 // scrape connects to the endpoint and produces metrics based on the response
 func (h *httpcheckScraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
-	if h.clients == nil || len(h.clients) == 0 {
+	if len(h.clients) == 0 {
 		return pmetric.NewMetrics(), errClientNotInit
 	}
 

diff --git a/receiver/mongodbatlasreceiver/log_decoder.go b/receiver/mongodbatlasreceiver/log_decoder.go
@@ -71,7 +71,7 @@ func decode4_2(logger *zap.Logger, r io.Reader) ([]model.LogEntry, error) {
 		}
 
 		submatches := mongo4_2LogRegex.FindStringSubmatch(scanner.Text())
-		if submatches == nil || len(submatches) != 6 {
+		if len(submatches) != 6 {
 			// Match failed for line; We will skip this line and continue processing others.
 			logger.Error("Entry did not match regex", zap.String("entry", scanner.Text()))
 			continue