Skip to content

Commit

Permalink
Disable flaky test TestW3CSpanTraceResourceExtraction (#9257)
Browse files Browse the repository at this point in the history
* Disable flaky test TestW3CSpanTraceResourceExtraction

* Use pdata.Traces back in constructW3CSpanData

Co-authored-by: Przemek Maciolek <58699843+pmm-sumo@users.noreply.github.com>
  • Loading branch information
dmitryax and pmm-sumo authored Apr 13, 2022
1 parent 6cb401f commit b7bf111
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions exporter/awsxrayexporter/awsxray_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ func TestXrayAndW3CSpanTraceResourceExtraction(t *testing.T) {
}

func TestW3CSpanTraceResourceExtraction(t *testing.T) {
t.Skip("Flaky test, see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/9255")
td := constructW3CSpanData()
logger, _ := zap.NewProduction()
assert.Len(t, extractResourceSpans(generateConfig(), logger, td), 0, "0 spans have xray trace id")
Expand Down Expand Up @@ -116,6 +117,7 @@ func constructSpanData() pdata.Traces {
return traces
}

// nolint:unused
func constructW3CSpanData() pdata.Traces {
resource := constructResource()
traces := pdata.NewTraces()
Expand Down

0 comments on commit b7bf111

Please sign in to comment.