[chore] [exporter/alertmanager] Fix default generator_url and update …

…readme
open-telemetry · Oct 24, 2023 · c750d54 · c750d54
1 parent 326c841
commit c750d54
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 7 deletions.
diff --git a/exporter/alertmanagerexporter/README.md b/exporter/alertmanagerexporter/README.md
@@ -11,7 +11,7 @@
 [contrib]: https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib
 <!-- end autogenerated section -->
 
-Exports Span Events as alerts to [Alertmanager](https://prometheus.io/docs/alerting/latest/alertmanager/) back-end.
+Exports OTEL Events (SpanEvent in Tracing added by AddEvent API) as Alerts to [Alertmanager] (https://prometheus.io/docs/alerting/latest/alertmanager/) back-end to notify Errors or Change events.
 
 Supported pipeline types: traces
 
@@ -56,5 +56,5 @@ exporters:
       initial_interval: 10s
       max_interval: 60s
       max_elapsed_time: 10m
-    generator_url: "otelcol:55681"
+    generator_url: "http://example.com/otelcol"
 ```
diff --git a/exporter/alertmanagerexporter/config_test.go b/exporter/alertmanagerexporter/config_test.go
@@ -42,7 +42,7 @@ func TestLoadConfig(t *testing.T) {
 		{
 			id: component.NewIDWithName(metadata.Type, "2"),
 			expected: &Config{
-				GeneratorURL:      "otelcol:55681",
+				GeneratorURL:      "http://example.com/otelcol",
 				DefaultSeverity:   "info",
 				SeverityAttribute: "foo",
 				TimeoutSettings: exporterhelper.TimeoutSettings{

diff --git a/exporter/alertmanagerexporter/factory.go b/exporter/alertmanagerexporter/factory.go
@@ -13,6 +13,8 @@ import (
 	"go.opentelemetry.io/collector/config/configopaque"
 	"go.opentelemetry.io/collector/exporter"
 	"go.opentelemetry.io/collector/exporter/exporterhelper"
+
+	"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alertmanagerexporter/internal/metadata"
 )
 
 const (
@@ -24,14 +26,14 @@ const (
 // NewFactory creates a factory for Alertmanager exporter
 func NewFactory() exporter.Factory {
 	return exporter.NewFactory(
-		typeStr,
+		metadata.Type,
 		createDefaultConfig,
-		exporter.WithTraces(createTracesExporter, stability))
+		exporter.WithTraces(createTracesExporter, metadata.TracesStability))
 }
 
 func createDefaultConfig() component.Config {
 	return &Config{
-		GeneratorURL:    "otelcol:55681",
+		GeneratorURL:    "http://example.com/otelcol",
 		DefaultSeverity: "info",
 		TimeoutSettings: exporterhelper.NewDefaultTimeoutSettings(),
 		RetrySettings:   exporterhelper.NewDefaultRetrySettings(),

diff --git a/exporter/alertmanagerexporter/go.mod b/exporter/alertmanagerexporter/go.mod
@@ -59,8 +59,14 @@ require (
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 
+replace github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal => ../../internal/coreinternal
+
 retract (
 	v0.76.2
 	v0.76.1
 	v0.65.0
 )
+
+replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil => ../../pkg/pdatautil
+
+replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatatest => ../../pkg/pdatatest
diff --git a/exporter/alertmanagerexporter/testdata/config.yaml b/exporter/alertmanagerexporter/testdata/config.yaml
@@ -1,7 +1,7 @@
 alertmanager:
 alertmanager/2:
   endpoint: "a.new.alertmanager.target:9093"
-  generator_url: "otelcol:55681"
+  generator_url: "http://example.com/otelcol"
   severity: "info"
   severity_attribute: "foo"
   tls: