Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/k8sobjects] e2e test #18395

Closed
Tracked by #15651
dmitryax opened this issue Feb 6, 2023 · 6 comments
Closed
Tracked by #15651

[receiver/k8sobjects] e2e test #18395

dmitryax opened this issue Feb 6, 2023 · 6 comments
Assignees
@jinja2
Labels
priority:p2 Medium receiver/k8sobjects

Comments

@dmitryax
Copy link
Member

dmitryax commented Feb 6, 2023

No description provided.

@dmitryax dmitryax mentioned this issue Feb 6, 2023
Closed
8 tasks
@dmitryax
Copy link
Member Author

dmitryax commented Feb 6, 2023

@harshit-splunk we started adding e2e tests for k8s components. Please feel free to take this one if you have some capacity

@fatsheep9146 fatsheep9146 changed the title [processor/k8sobjects] e2e test [receiver/k8sobjects] e2e test Feb 7, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 10, 2023
@dmitryax dmitryax removed the Stale label Apr 10, 2023
@omrozowicz-splunk omrozowicz-splunk mentioned this issue May 5, 2023
Closed
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 12, 2023
@atoulme atoulme removed the Stale label Jul 22, 2023
@dmitryax dmitryax added the help wanted Extra attention is needed label Aug 9, 2023
@TylerHelmuth TylerHelmuth mentioned this issue Aug 24, 2023
Merged
TylerHelmuth added a commit that referenced this issue Sep 11, 2023
@TylerHelmuth @evan-bradley
[receiver/k8sobjects] Add logic to properly handle 410 responses (#26098
a4999eb 
)

**Description:** 
Updates the receiver to properly handle 410 response code. The
expectations for what clients should do when a 410 is received can be
found here:
https://kubernetes.io/docs/reference/using-api/api-concepts/#410-gone-responses.

I originally implemented this feature directly in `startWatch`,
rebuilding the watcher and res channel within the for loop, but I grew
concerned about making sure everything stopped correctly. I took a look
at the retry watcher's implementation and reused its concepts for this
implementation. If it is overcomplicated we can go back to my original
idea.

**Link to tracking Issue:** <Issue number if applicable>

Closes
#24903

**Testing:** <Describe what testing was performed and which tests were
added.>

Tested locally. Unit tests proved to be extremely challenging since I
couldn't figure out how to get the mock to produce a 410. We really need
e2e tests
(#18395).

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
@jinja2
Copy link
Contributor

jinja2 commented Sep 27, 2023

I am trying this receiver for some usecases and can add an e2e test. Please assign it to me.

@TylerHelmuth TylerHelmuth removed the help wanted Extra attention is needed label Sep 27, 2023
@TylerHelmuth
Copy link
Member

Thank you!

@jinja2 jinja2 mentioned this issue Oct 9, 2023
Merged
TylerHelmuth pushed a commit that referenced this issue Oct 11, 2023
@jinja2
[chore][receiver/k8sobjects] add tests for k8sobjectsreceiver (#27569)
918a81e 
**Description:** Adds an e2e test for the k8sobjectsreceiver to github
workflow
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:**
[18395](#18395)
@atoulme
Copy link
Contributor

atoulme commented Oct 17, 2023

Closing as complete, thanks @jinja2

@atoulme atoulme closed this as completed Oct 17, 2023
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this issue Oct 18, 2023
@jinja2 @JaredTan95
[chore][receiver/k8sobjects] add tests for k8sobjectsreceiver (open-t…
179963c 
…elemetry#27569)

**Description:** Adds an e2e test for the k8sobjectsreceiver to github
workflow
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:**
[18395](open-telemetry#18395)
@jinja2 jinja2 mentioned this issue Oct 20, 2023
Closed
6 tasks
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@jinja2 @jmsnll
[chore][receiver/k8sobjects] add tests for k8sobjectsreceiver (open-t…
752981c 
…elemetry#27569)

**Description:** Adds an e2e test for the k8sobjectsreceiver to github
workflow
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:**
[18395](open-telemetry#18395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinja2 jinja2

Labels
priority:p2 Medium receiver/k8sobjects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@atoulme @dmitryax @TylerHelmuth @jinja2