Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/opampsupervisor] Handle OpAMP connection settings messages #21043

Closed
Tracked by #24327
evan-bradley opened this issue Apr 18, 2023 · 3 comments
Closed
Tracked by #24327

[cmd/opampsupervisor] Handle OpAMP connection settings messages #21043

evan-bradley opened this issue Apr 18, 2023 · 3 comments
Assignees
@srikanthccv
Labels
cmd/opampsupervisor enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed

Comments

@evan-bradley
Copy link
Contributor

Component(s)

No response

Is your feature request related to a problem? Please describe.

Per the OpAMP specification, OpAMP servers should be able to configure network connection configurations for connections that agents make. Since it is acting on behalf of the Collector as an OpAMP agent, the Supervisor should support these messages.

Describe the solution you'd like

Handle the ConnectionSettingsOffers, in particular fields with the following message types:

  1. OpAMPConnectionSettings
  2. TelemetryConnectionSettings

Describe alternatives you've considered

No response

Additional context

An issue for handling OtherConnectionSettings messages will follow.
@evan-bradley evan-bradley added the enhancement New feature or request label Apr 18, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jun 19, 2023
@mwear mwear added never stale Issues marked with this label will be never staled and automatically removed and removed Stale never stale Issues marked with this label will be never staled and automatically removed labels Jun 21, 2023
@evan-bradley evan-bradley added the never stale Issues marked with this label will be never staled and automatically removed label Jul 17, 2023
@evan-bradley evan-bradley mentioned this issue Jul 17, 2023
Open
10 tasks
srikanthccv added a commit to srikanthccv/opentelemetry-collector-contrib that referenced this issue Dec 19, 2023
@srikanthccv
Handle OpAMP connection settings
5e06efa 
Part of open-telemetry#21043
@srikanthccv
Copy link
Member

@evan-bradley please assign this to me. I started working on this.

@srikanthccv srikanthccv mentioned this issue Dec 30, 2023
Merged
MovieStoreGuy pushed a commit that referenced this issue Apr 9, 2024
@srikanthccv @evan-bradley
[cmd/opampsupervisor] Handle OpAMP connection settings (#30237)
4edca20 
**Link to tracking Issue:** <Issue number if applicable>

Part of #21043; based on top of
#29848
to add test

**Testing:** <Describe what testing was performed and which tests were
added.>

Added integration test

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
@evan-bradley
Copy link
Contributor Author

Closing as resolved via #30237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanthccv srikanthccv

Labels
cmd/opampsupervisor enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mwear @evan-bradley @srikanthccv