-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/opampsupervisor] Persist sections of Collector's effective config #21078
Comments
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
I want to pick this up. @evan-bradley some clarifying questions, I can see the need to persist the config when Server offers a new remote config or connection settings, but what does it mean to persist configs in |
Sorry, maybe I could have phrased it a little differently. We want to persist those messages upon receiving them, then if the Supervisor is restarted, use the previously persisted config fragments to start the Collector on Supervisor startup, so the Collector is started even if a message hasn't been yet received from the OpAMP server. |
#30807) …tings **Description:** <Describe what has changed.> Persists the configs contained in the AgentRemoteConfig and ConnectionSettings messages to be used on startup before any messages have been received from the OpAMP server. If the capability corresponding to the message for the config is disabled, then the config is not merged into the Collector's effective configuration **Link to tracking Issue:** Part of #21078 **Testing:** Added e2e test **Documentation:** <Describe the documentation added.>
Component(s)
No response
Is your feature request related to a problem? Please describe.
OpAMP offers the AgentRemoteConfig and ConnectionSettings messages to help create an effective configuration to give to the Collector. The Supervisor needs to persist these to allow the effective config to be composed on startup even if the OpAMP server doesn't send a message containing these configs.
Describe the solution you'd like
Persist the configs contained in the AgentRemoteConfig and ConnectionSettings messages to be used on startup before any messages have been received from the OpAMP server. If the capability corresponding to the message for the config is disabled, ensure the config is not merged into the Collector's effective configuration.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: