Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] Do we need flushUncombined in the recombine operator? #22140

Closed
dmitryax opened this issue May 20, 2023 · 6 comments · Fixed by #30999
Closed

[pkg/stanza] Do we need flushUncombined in the recombine operator? #22140

dmitryax opened this issue May 20, 2023 · 6 comments · Fixed by #30999
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pkg/stanza

Comments

@dmitryax
Copy link
Member

dmitryax commented May 20, 2023

There are a couple of places where we forcefully flush all the batch uncombined:

  • when batching reaches MaxSources limit
  • when Shutdown signal is received.

Question: Why this flush has to be uncombined? Can we do the regular flush with combined batches? It likely won't take more time, and we will not need to keep all the entries during the batching, just one (first or latest).

@dmitryax dmitryax added enhancement New feature or request question Further information is requested pkg/stanza labels May 20, 2023
@github-actions
Copy link
Contributor

Pinging code owners for pkg/stanza: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

I agree we don't need it. Similar issue here, just hasn't been a priority yet. #10281

@dmitryax dmitryax added help wanted Extra attention is needed good first issue Good for newcomers and removed question Further information is requested labels May 22, 2023
@shivanshuraj1333
Copy link
Member

I'd like to work on it, can I get it assigned to me, thanks!

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.
  • pkg/stanza: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.
  • pkg/stanza: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pkg/stanza
Projects
None yet
3 participants