Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the collector's prometheus receiver to do protobuf negotiation #27027

Closed
jaronoff97 opened this issue Sep 20, 2023 · 5 comments
Closed

Allow the collector's prometheus receiver to do protobuf negotiation #27027

jaronoff97 opened this issue Sep 20, 2023 · 5 comments
Labels
enhancement New feature or request receiver/prometheus Prometheus receiver

Comments

@jaronoff97
Copy link
Contributor

Component(s)

receiver/prometheus

Is your feature request related to a problem? Please describe.

Right now if I wanted to scrape metrics using the protobuf format for native-histograms, i wouldn't be able to because they are only available via the protobuf format.

Describe the solution you'd like

I would like to be able to set this option.

Describe alternatives you've considered

No response

Additional context

No response
@jaronoff97 jaronoff97 added enhancement New feature or request needs triage New item requiring triage labels Sep 20, 2023
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Sep 20, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dashpole
Copy link
Contributor

+1. Do you know if it is safe to always set that option? Or does it need to be configurable?

Another question is the default. If native histograms are going to be recommended in the future, we might want to at least enable this by default.

@jaronoff97 jaronoff97 mentioned this issue Sep 20, 2023
Merged
@jaronoff97
Copy link
Contributor Author

I'm not sure if it's safe to always set as an option, i'm making it configurable to start so as to not disrupt anyones configuration.

@jaronoff97
Copy link
Contributor Author

I think we could adjust the default when this is complete

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Sep 20, 2023
codeboten pushed a commit that referenced this issue Sep 21, 2023
@jaronoff97 @dashpole
[prometheusreceiver] Enable proto negotiation (#27030)
135e41c 
Exposes the protobuf negotiation flag for the scrape manager.
#27027

---------

Co-authored-by: David Ashpole <dashpole@google.com>
@codeboten
Copy link
Contributor

Solved by #27030

@github-actions github-actions bot mentioned this issue Sep 26, 2023
Open
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@jaronoff97 @dashpole @jmsnll
[prometheusreceiver] Enable proto negotiation (open-telemetry#27030)
348d033 
Exposes the protobuf negotiation flag for the scrape manager.
open-telemetry#27027

---------

Co-authored-by: David Ashpole <dashpole@google.com>
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request receiver/prometheus Prometheus receiver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@codeboten @dashpole @jaronoff97 @crobert-1