Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to create and send markers to the honeycomb marker exporter #27666

Closed
fchikwekwe opened this issue Oct 13, 2023 · 1 comment
Closed

Add ability to create and send markers to the honeycomb marker exporter #27666

fchikwekwe opened this issue Oct 13, 2023 · 1 comment
Labels
enhancement New feature or request Stale

Comments

@fchikwekwe
Copy link
Contributor

fchikwekwe commented Oct 13, 2023 •
edited
Loading

Component(s)

exporter/honeycombmarker

Is your feature request related to a problem? Please describe.

This issue outlines the functional pieces of the honeycomb marker exporter.

The flow of this component should specify a condition to filter out logs that do not pass this condition and create a marker for logs that do.

Describe the solution you'd like

The exporter should then call out the honeycomb API and use the Create Marker function. We will not support updating/deleting markers that already exist.

In the initial config for this exporter we supported sending Markers that specify color instead of type. Type is a more explicit way of creating initial Markers and Markers that only specify color would have to be updated with Type later on. To this end we will only support sending Markers that specify Type via the exporter. Color can be set via Marker Settings in the Honeycomb Markers API. Color cannot be set using the Create Marker function. We could need to both create and update the Marker in order to support specifying color.

We will only be sending environment wide markers using the __all__ endpoint.

DOD:

  • Only support markers that specify type; do not support markers that specify color

Describe alternatives you've considered

No response

Additional context

No response
@fchikwekwe fchikwekwe added enhancement New feature or request needs triage New item requiring triage labels Oct 13, 2023
@fchikwekwe fchikwekwe mentioned this issue Oct 13, 2023
Closed
2 tasks
This was referenced Oct 17, 2023
Closed
Closed
@github-actions github-actions bot mentioned this issue Oct 31, 2023
Closed
@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 31, 2023
@fchikwekwe fchikwekwe mentioned this issue Nov 2, 2023
Merged
@fchikwekwe fchikwekwe mentioned this issue Nov 14, 2023
Merged
TylerHelmuth added a commit that referenced this issue Nov 16, 2023
@fchikwekwe @TylerHelmuth
feat: add ability to filter and export markers (#27862)
01559fb 
**Description:** This add logic to filter logs based on log conditions
and sent desired logs as event markers to the honeycomb marker api.

**Link to tracking Issue:**
#27666

**Testing:** Unit testing for log exporter and config. Added component
testing to `otelcontribcol`.

**Documentation:** README describing component usage

Screenshot of exported markers showing up in Honeycomb
<img width="1225" alt="Screenshot 2023-11-14 at 1 27 49 PM"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/35741033/128d689a-cf1e-4959-9df3-6c88248a7fdb">

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
@TylerHelmuth TylerHelmuth mentioned this issue Nov 16, 2023
Merged
TylerHelmuth added a commit that referenced this issue Nov 16, 2023
@TylerHelmuth
[exporter/honeycombmarker] Fix default url and dataset_slug (#29309)
d376053 
**Description:** 
Fixes an issue with an incorrect default url. Also fixes issue where
dataset slug was required.

**Link to tracking Issue:** <Issue number if applicable>
Related to
#27666

**Testing:** <Describe what testing was performed and which tests were
added.>
Added new tests and tested manually.

**Documentation:** <Describe the documentation added.>
 Updated up README
TylerHelmuth added a commit that referenced this issue Nov 16, 2023
@fchikwekwe @TylerHelmuth
feat: change honeycombmarkerexporter to alpha (#29272)
e3da924 
**Description:** Update Honeycomb Marker Exporter to alpha status

**Link to tracking Issue:** #27666 

**Testing:** 

**Documentation:**

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
graphaelli pushed a commit to graphaelli/opentelemetry-collector-contrib that referenced this issue Nov 17, 2023
@fchikwekwe @TylerHelmuth @graphaelli
feat: add ability to filter and export markers (open-telemetry#27862)
7118395 
**Description:** This add logic to filter logs based on log conditions
and sent desired logs as event markers to the honeycomb marker api.

**Link to tracking Issue:**
open-telemetry#27666

**Testing:** Unit testing for log exporter and config. Added component
testing to `otelcontribcol`.

**Documentation:** README describing component usage

Screenshot of exported markers showing up in Honeycomb
<img width="1225" alt="Screenshot 2023-11-14 at 1 27 49 PM"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/35741033/128d689a-cf1e-4959-9df3-6c88248a7fdb">

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
graphaelli pushed a commit to graphaelli/opentelemetry-collector-contrib that referenced this issue Nov 17, 2023
@TylerHelmuth @graphaelli
[exporter/honeycombmarker] Fix default url and dataset_slug (open-tel…
6020982 
…emetry#29309)

**Description:** 
Fixes an issue with an incorrect default url. Also fixes issue where
dataset slug was required.

**Link to tracking Issue:** <Issue number if applicable>
Related to
open-telemetry#27666

**Testing:** <Describe what testing was performed and which tests were
added.>
Added new tests and tested manually.

**Documentation:** <Describe the documentation added.>
 Updated up README
graphaelli pushed a commit to graphaelli/opentelemetry-collector-contrib that referenced this issue Nov 17, 2023
@fchikwekwe @TylerHelmuth @graphaelli
feat: change honeycombmarkerexporter to alpha (open-telemetry#29272)
f43bb9d 
**Description:** Update Honeycomb Marker Exporter to alpha status

**Link to tracking Issue:** open-telemetry#27666 

**Testing:** 

**Documentation:**

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
aishyandapalli pushed a commit to aishyandapalli/opentelemetry-collector-contrib that referenced this issue Nov 17, 2023
@fchikwekwe @TylerHelmuth @aishyandapalli
feat: change honeycombmarkerexporter to alpha (open-telemetry#29272)
dc18ead 
**Description:** Update Honeycomb Marker Exporter to alpha status

**Link to tracking Issue:** open-telemetry#27666 

**Testing:** 

**Documentation:**

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@fchikwekwe @TylerHelmuth @RoryCrispin
feat: add ability to filter and export markers (open-telemetry#27862)
3fdf840 
**Description:** This add logic to filter logs based on log conditions
and sent desired logs as event markers to the honeycomb marker api.

**Link to tracking Issue:**
open-telemetry#27666

**Testing:** Unit testing for log exporter and config. Added component
testing to `otelcontribcol`.

**Documentation:** README describing component usage

Screenshot of exported markers showing up in Honeycomb
<img width="1225" alt="Screenshot 2023-11-14 at 1 27 49 PM"
src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/35741033/128d689a-cf1e-4959-9df3-6c88248a7fdb">

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@TylerHelmuth @RoryCrispin
[exporter/honeycombmarker] Fix default url and dataset_slug (open-tel…
52465c8 
…emetry#29309)

**Description:** 
Fixes an issue with an incorrect default url. Also fixes issue where
dataset slug was required.

**Link to tracking Issue:** <Issue number if applicable>
Related to
open-telemetry#27666

**Testing:** <Describe what testing was performed and which tests were
added.>
Added new tests and tested manually.

**Documentation:** <Describe the documentation added.>
 Updated up README
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@fchikwekwe @TylerHelmuth @RoryCrispin
feat: change honeycombmarkerexporter to alpha (open-telemetry#29272)
f82c6c8 
**Description:** Update Honeycomb Marker Exporter to alpha status

**Link to tracking Issue:** open-telemetry#27666 

**Testing:** 

**Documentation:**

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TylerHelmuth @fchikwekwe @crobert-1