Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go install doesn't work for telemetrygen #27855

Closed
theletterf opened this issue Oct 19, 2023 · 4 comments · Fixed by #27878 or #28565
Closed

Go install doesn't work for telemetrygen #27855

theletterf opened this issue Oct 19, 2023 · 4 comments · Fixed by #27878 or #28565
Assignees
@mx-psi
Labels
bug Something isn't working cmd/telemetrygen telemetrygen command priority:p1 High

Comments

@theletterf
Copy link
Member

theletterf commented Oct 19, 2023 •
edited
Loading

Component(s)

cmd/telemetrygen

What happened?

Description

I've tried the following command from the telemetrygen README file:

go install github.com/open-telemetry/opentelemetry-collector-contrib/cmd/telemetrygen@latest

On Ubuntu 23.10, with Go 1.21.1, this is what I get:

go: github.com/open-telemetry/opentelemetry-collector-contrib/cmd/telemetrygen@latest (in github.com/open-telemetry/opentelemetry-collector-contrib/cmd/telemetrygen@v0.87.0):
	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

This makes it rather difficult if you only need that binary. I suspect this might happen to more packages.

I ended up pulling the entire contrib repo and running go build from the telemetrygen directory. That gave the binary I needed for a get started tutorial.

Collector version

0.87.0

Environment information

Environment

OS: Ubuntu 23.10
Compiler(if manually compiled): Go 1.21.1
@theletterf theletterf added bug Something isn't working needs triage New item requiring triage labels Oct 19, 2023
@theletterf theletterf mentioned this issue Oct 19, 2023
Closed
@crobert-1 crobert-1 added the cmd/telemetrygen telemetrygen command label Oct 19, 2023
@github-actions
Copy link
Contributor

Pinging code owners for cmd/telemetrygen: @mx-psi @codeboten. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mx-psi
Copy link
Member

mx-psi commented Oct 19, 2023

This happens since #26668 because of

opentelemetry-collector-contrib/cmd/telemetrygen/main_test.go

Line 26 in 1842e13

endpoint := testutil.GetAvailableLocalAddress(t)

I think we can split these tests into a separate module. What do you think @codeboten @atoulme ?

@mx-psi mx-psi added the priority:p1 High label Oct 19, 2023
This was referenced Oct 20, 2023
Merged
Open
@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 20, 2023
mx-psi added a commit that referenced this issue Oct 20, 2023
@mx-psi
[cmd/telemetrygen] Move end to end tests to separate module (#27878)
a504159 
**Description:** 

Move `cmd/telemetrygen` integration tests to separate module, to avoid
local replaces. Follow up to #26668.

**Link to tracking Issue:** Fixes #27855
@github-actions github-actions bot mentioned this issue Oct 24, 2023
Closed
@mx-psi mx-psi mentioned this issue Oct 24, 2023
Merged
mx-psi added a commit that referenced this issue Oct 24, 2023
@mx-psi
[cmd/telemetrygen] Remove remaining replace statement (#28565)
85fba96 
**Description:** #27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes #27855
@mx-psi
Copy link
Member

mx-psi commented Oct 24, 2023

#27878 did not fix this, but #28565 did. I intend to make a v0.88.1 release only for telemetrygen so the install command works again

@mx-psi mx-psi reopened this Oct 24, 2023
mx-psi added a commit to mx-psi/opentelemetry-collector-contrib that referenced this issue Oct 24, 2023
@mx-psi
[cmd/telemetrygen] Remove remaining replace statement (open-telemetry…
3fa1e4b 
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855

(cherry picked from commit 85fba96)
@mx-psi
Copy link
Member

mx-psi commented Oct 25, 2023

This is now fixed, I tagged v0.88.1: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/cmd/telemetrygen/v0.88.1

@mx-psi mx-psi closed this as completed Oct 25, 2023
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this issue Oct 27, 2023
@mx-psi @sigilioso
[cmd/telemetrygen] Move end to end tests to separate module (open-tel…
7583ced 
…emetry#27878)

**Description:** 

Move `cmd/telemetrygen` integration tests to separate module, to avoid
local replaces. Follow up to open-telemetry#26668.

**Link to tracking Issue:** Fixes open-telemetry#27855
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this issue Oct 27, 2023
@mx-psi @sigilioso
[cmd/telemetrygen] Remove remaining replace statement (open-telemetry…
b665836 
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@mx-psi @jmsnll
[cmd/telemetrygen] Move end to end tests to separate module (open-tel…
9982776 
…emetry#27878)

**Description:** 

Move `cmd/telemetrygen` integration tests to separate module, to avoid
local replaces. Follow up to open-telemetry#26668.

**Link to tracking Issue:** Fixes open-telemetry#27855
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@mx-psi @jmsnll
[cmd/telemetrygen] Remove remaining replace statement (open-telemetry…
75f0e87 
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@mx-psi @RoryCrispin
[cmd/telemetrygen] Remove remaining replace statement (open-telemetry…
5e10bfc 
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855
@mx-psi mx-psi mentioned this issue Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mx-psi mx-psi

Labels
bug Something isn't working cmd/telemetrygen telemetrygen command priority:p1 High
Projects
None yet
Milestone
No milestone
3 participants
@theletterf @mx-psi @crobert-1