[CI] opentelemetry-collector-contrib builds linux/arm64 binary with wrong arm version

[atoulme]

Component(s)

No response

What happened?

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7021964134/job/19105712226 as example.

It runs:

make GOOS=linux GOARCH=arm64 GOARM=7 otelcontribcol

It should run:

make GOOS=linux GOARCH=arm64 GOARM=8 otelcontribcol

Collector version

latest

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[crobert-1]

I believe this is coming from here. Blame shows it was updated to version 7 a few months ago here.

Can you provide more context as to why it should be 8 instead? From documentation it looks like 8 isn't a valid value, unless I'm missing something.

[atoulme]

it's possible it should not be set, but arm 64 bit is armv8.

[crobert-1]

Good point, it looks like when GOARCH=arm64 we need to leave GOARM unset. Official source.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

[mowies]

I think this is basically almost a typo. The PR #23436 tried to add a single matrix entry to the cross-compile job, but accidentally added three:

- os: linux
- arch: arm
- arm: 7

This should have been:

- os: linux
  arch: arm
  arm: 7

I will file a PR to fix that.
If you could assign the issue to me, that would be great :)

[mowies]

Since this is an older issue, I'll ping @crobert-1 here :)