Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of ReportFatalError in generated tests #30579

Closed
Tracked by #30501
atoulme opened this issue Jan 16, 2024 · 1 comment · Fixed by #30903
Closed
Tracked by #30501

Remove use of ReportFatalError in generated tests #30579

atoulme opened this issue Jan 16, 2024 · 1 comment · Fixed by #30903
Assignees
@atoulme
Labels
cmd/mdatagen mdatagen command

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 16, 2024

Component(s)

cmd/mdatagen

Describe the issue you're reporting

The generated tests use an implementation of Host that uses ReportFatalError to report errors.

Remove this implementation of Host from generated code as it is ok for components to report errors during the lifecycle tests.
@atoulme atoulme added the needs triage New item requiring triage label Jan 16, 2024
@github-actions github-actions bot added the cmd/mdatagen mdatagen command label Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme mentioned this issue Jan 16, 2024
Closed
21 tasks
@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 17, 2024
@github-actions github-actions bot mentioned this issue Jan 23, 2024
Closed
@atoulme atoulme self-assigned this Jan 31, 2024
This was referenced Jan 31, 2024
Merged
Merged
djaglowski pushed a commit that referenced this issue Jan 31, 2024
@atoulme
[chore] remove component.Host implementation from generated tests (#3…
ebec5ee 
…0903)

**Description:**
The `assertNoErrorHost` struct was used in tests to check that no error
was thrown. However, it uses a deprecated function `ReportFatalError` we
are trying to remove from our code.

**Link to tracking Issue:** 
Fixes
#30579
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@atoulme @cparkins
[chore] remove component.Host implementation from generated tests (op…
5b58659 
…en-telemetry#30903)

**Description:**
The `assertNoErrorHost` struct was used in tests to check that no error
was thrown. However, it uses a deprecated function `ReportFatalError` we
are trying to remove from our code.

**Link to tracking Issue:** 
Fixes
open-telemetry#30579
bogdandrutu pushed a commit to open-telemetry/opentelemetry-collector that referenced this issue Feb 3, 2024
@atoulme
[mdatagen] Remove use of ReportFatalError in generated tests (#9439)
5c176a9 
**Description:**
Remove use of ReportFatalError in generated tests

**Link to tracking Issue:**

open-telemetry/opentelemetry-collector-contrib#30579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atoulme atoulme

Labels
cmd/mdatagen mdatagen command
Projects
None yet
Milestone
No milestone
2 participants
@atoulme @crobert-1