Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/pprofextension] Remove deprecated use of host.ReportFatalError #30584

Closed
Tracked by #30501
atoulme opened this issue Jan 16, 2024 · 1 comment · Fixed by #30647
Closed
Tracked by #30501

[extension/pprofextension] Remove deprecated use of host.ReportFatalError #30584

atoulme opened this issue Jan 16, 2024 · 1 comment · Fixed by #30647
Assignees
@codeboten
Labels
bug Something isn't working extension/pprof

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 16, 2024

Component(s)

extension/pprof

Describe the issue you're reporting

Refactor to remove use of host.ReportFatalError, you can use settings.TelemetrySettings.ReportStatus(component.NewFatalErrorEvent(err)) instead.

See #30505 for an example.
@atoulme atoulme added the needs triage New item requiring triage label Jan 16, 2024
@atoulme atoulme mentioned this issue Jan 16, 2024
Closed
21 tasks
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added bug Something isn't working and removed needs triage New item requiring triage labels Jan 16, 2024
@codeboten codeboten self-assigned this Jan 17, 2024
codeboten pushed a commit that referenced this issue Jan 17, 2024
[chore] pprof extension ReportFatalError -> ReportStatus
54e4531 
Remove use of deprecated host.ReportFatalError

Linked to #30501

Fixes #30584

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten mentioned this issue Jan 17, 2024
Merged
codeboten pushed a commit that referenced this issue Jan 17, 2024
[chore] pprof extension ReportFatalError -> ReportStatus (#30647)
2a21f5d 
Remove use of deprecated host.ReportFatalError

Linked to
#30501

Fixes #30584

Signed-off-by: Alex Boten <aboten@lightstep.com>
mfyuce pushed a commit to mfyuce/opentelemetry-collector-contrib that referenced this issue Jan 18, 2024
@mfyuce
[chore] pprof extension ReportFatalError -> ReportStatus (open-teleme…
cd1a06a 
…try#30647)

Remove use of deprecated host.ReportFatalError

Linked to
open-telemetry#30501

Fixes open-telemetry#30584

Signed-off-by: Alex Boten <aboten@lightstep.com>
@github-actions github-actions bot mentioned this issue Jan 23, 2024
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@cparkins
[chore] pprof extension ReportFatalError -> ReportStatus (open-teleme…
c558bb7 
…try#30647)

Remove use of deprecated host.ReportFatalError

Linked to
open-telemetry#30501

Fixes open-telemetry#30584

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
bug Something isn't working extension/pprof
Projects
None yet
Milestone
No milestone
3 participants
@atoulme @codeboten @crobert-1