You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If collector bootstrapping fails, the Stop method will not be called for the collector command. This causes the collector to outlive the supervisor, which ends up blocking any attempts for the supervisor to start up again (collector occupies port 8888)
I don't have very much experience with the area of the collector, but from your description and PR it makes sense to me. Thanks for filing and submitting a fix!
… in bootstrapping (#31944)
**Description:**
* Fix early exits not shutting down client/server in bootstrapping
**Link to tracking Issue:** Closes#31943
**Testing:**
I tested manually adding errors into the code. There isn't a good,
consistent way to add e.g. the timeout error as-is.
---------
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Component(s)
cmd/opampsupervisor
What happened?
Description
If collector bootstrapping fails, the Stop method will not be called for the collector command. This causes the collector to outlive the supervisor, which ends up blocking any attempts for the supervisor to start up again (collector occupies port 8888)
opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/supervisor.go
Line 308 in 011256c
Solution would be to use
defer
statements to ensure the command is always stopped before returning from thegetBootstrapInfo
method.Collector version
f8627a7
Environment information
Environment
OS: macos
Compiler(if manually compiled): go 1.22
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: