[testbed/mockdatasenders/mockdatadogagentexporter] Broken load test #33577
Comments
crobert-1
added
needs triage
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
This has been broken at least since February :( |
|
@codeboten if that's fine with you, I'd like to look into this :) |
|
Actually, I managed to debug and investigate this on my personal fork, with success it seems 👍🏼 |
|
I filed a fix PR for this @codeboten @crobert-1 :) The array of test names was not parsed correctly in the |
**Description:** This PR fixes the load test pipeline which was broken for a while. The array of tests was not iterated over correctly in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/workflows/scripts/setup_e2e_tests.sh and the first iteration of the loop resulted in the whole array being added to the matrix instead of just the first entry of the array. I introduced a different way to read in the array of tests at the start of the setup bash script, which works now. [source for the solution](https://stackoverflow.com/a/10586169) **Link to tracking Issue:** Fixes #33577 **Testing:** Tested successfully on my personal fork. This is a [link to a load test run](https://github.com/mowies/opentelemetry-collector-contrib/actions/runs/9761599340) where the matrix is correctly parsed by github actions. Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
|
Now, that the load tests are running again, it seems that they have some other issues as well. Pipeline runs are still red... Taking this run for example: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9769350633 The load tests are successfully executed but something is still broken with the result upload. |
|
@codeboten @crobert-1 I filed a follow-up PR that fixes the rest of the load test pipeline. Although I noticed that some tests are broken.. |
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR fixes more issues with the load test pipeline. Specifically, it adjusts some things around artifact up/download which is needed as a result of the breaking changes in GitHub Actions artifacts listed [here](https://github.com/actions/upload-artifact#breaking-changes:~:text=Uploading%20to%20the%20same%20named,you%20will%20encounter%20an%20error.). Also, it removes the issue generation step which seems far outdated as it's failing with missing CircleCI env variables. Also, I noticed that a few of the load tests fail consistently. To test. the pipeline, I had to comment them out. Not sure, what to do with them... **Link to tracking Issue:** Part of #33577 Follow up to #33860 **Testing:** Testing done on my personal fork. Link to working pipeline run: [Green run with some broken tests commented out, but pipeline working](https://github.com/mowies/opentelemetry-collector-contrib/actions/runs/9789652148) [Red run with broken tests](https://github.com/mowies/opentelemetry-collector-contrib/actions/runs/9790395589) **Documentation:** none added --------- Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Component(s)
testbed, testbed/mockdatasenders/mockdatadogagentexporter
Describe the issue you're reporting
The
load testsGitHub action is currently broken with the following error from this line:Upon further investigation, the failing variable expansion is a result of the
.github/workflows/scripts/setup_e2e_tests.shfailing thesplitloadtestsstep of the dependent action:The text was updated successfully, but these errors were encountered: