Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonlogencoding only handles the first log record's body of the pdata logs payload #34064

Closed
atoulme opened this issue Jul 12, 2024 · 3 comments · Fixed by #36156
Closed

jsonlogencoding only handles the first log record's body of the pdata logs payload #34064

atoulme opened this issue Jul 12, 2024 · 3 comments · Fixed by #36156
Labels
closed as inactive extension/encoding/jsonlogencoding Stale

Comments

@atoulme
Copy link
Contributor

atoulme commented Jul 12, 2024 

          Well, sure, but could you possibly marshal them all individually and send back the data as separate payloads? You are going to force customers to have one log record per payload which is a bit of a trap. The same feedback applies to `jsonlogencoding`, looks like. I will open an issue for that.

Originally posted by @atoulme in #34047 (comment)
@atoulme atoulme mentioned this issue Jul 12, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for extension/encoding/jsonlogencoding: @VihasMakwana @atoulme. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot mentioned this issue Jul 16, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 16, 2024
@TorsteinOtterlei TorsteinOtterlei mentioned this issue Sep 20, 2024
Open
@mauri870 mauri870 mentioned this issue Sep 26, 2024
Closed
@atoulme atoulme mentioned this issue Nov 3, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
MovieStoreGuy pushed a commit that referenced this issue Dec 11, 2024
@atoulme
[extension/jsonlogencoding] Support marshaling multiple logs (#36156)
421d710 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Change how logs are marshaled. Instead of marshaling just the first log,
marshal all logs into a JSON array.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes #34064
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@atoulme @sbylica-splunk
[extension/jsonlogencoding] Support marshaling multiple logs (open-te…
6ee20fb 
…lemetry#36156)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Change how logs are marshaled. Instead of marshaling just the first log,
marshal all logs into a JSON array.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#34064
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Jan 13, 2025
@atoulme @AkhigbeEromo
[extension/jsonlogencoding] Support marshaling multiple logs (open-te…
49745d1 
…lemetry#36156)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Change how logs are marshaled. Instead of marshaling just the first log,
marshal all logs into a JSON array.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#34064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed as inactive extension/encoding/jsonlogencoding Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[extension/jsonlogencoding] Support marshaling multiple logs atoulme/opentelemetry-collector-contrib
2 participants
@atoulme @crobert-1