Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop processor.transform.ConvertBetweenSumAndGaugeMetricContext feature gate #34567

Closed
jmcarp opened this issue Aug 9, 2024 · 6 comments · Fixed by #36216
Closed

Drop processor.transform.ConvertBetweenSumAndGaugeMetricContext feature gate #34567

jmcarp opened this issue Aug 9, 2024 · 6 comments · Fixed by #36216
Labels
processor/transform Transform processor

Comments

@jmcarp
Copy link
Contributor

jmcarp commented Aug 9, 2024

Component(s)

processor/transform

Describe the issue you're reporting

There's an alpha feature gate called processor.transform.ConvertBetweenSumAndGaugeMetricContext. But the feature seems straightforward and works well, as far as I can tell. Has it been available long enough to drop the feature gate?

@jmcarp jmcarp added the needs triage New item requiring triage label Aug 9, 2024
@github-actions github-actions bot added the processor/transform Transform processor label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@TylerHelmuth
Copy link
Member

Thanks for reminding me about this gate. We should continue forward through the standard feature gate process: https://github.com/open-telemetry/opentelemetry-collector/tree/main/featuregate#feature-lifecycle

@TylerHelmuth TylerHelmuth removed the needs triage New item requiring triage label Aug 9, 2024
TylerHelmuth added a commit that referenced this issue Aug 22, 2024
…34580)

**Description:** promote the
`processor.transform.ConvertBetweenSumAndGaugeMetricContext` feature
flag from `alpha` to `beta`.

**Link to tracking Issue:** #34567

**Testing:** I modified the unit test to check when the feature flag is
enabled and disabled.

---------

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
@ernest-liftoff
Copy link

hello, using 0.108 collectors, i can no longer use the convert_gauge_to_sum function.

is this expected?

Error: invalid configuration: processors::transform/correct_temporality: unable to parse OTTL statement "convert_gauge_to_sum(\"cumulative\", true)": undefined function "convert_gauge_to_sum"
2024/09/05 05:40:52 collector server run finished with error: invalid configuration: processors::transform/correct_temporality: unable to parse OTTL statement "convert_gauge_to_sum(\"cumulative\", true)": undefined function "convert_gauge_to_sum"

@wildum
Copy link
Contributor

wildum commented Sep 5, 2024

That's because the feature gate "processor.transform.ConvertBetweenSumAndGaugeMetricContext" was switched from Alpha to Beta. In Alpha stage, the gate is disabled by default but in Beta stage it is enabled by default.
If you want the same behavior as before, you need to disable it explicitly:
--feature-gates -processor.transform.ConvertBetweenSumAndGaugeMetricContext

@wildum
Copy link
Contributor

wildum commented Sep 5, 2024

else you need to change the context. It's not on the "datapoint" context anymore but on the "metric" context that these functions should be used.
I think that the readme update was forgotten: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/transformprocessor
I will create a PR

evan-bradley pushed a commit that referenced this issue Sep 5, 2024
…o_sum (#35022)

**Description:** The feature gate
"processor.transform.ConvertBetweenSumAndGaugeMetricContext" was updated
from Alpha to Beta. This means that it is now enabled by default. The
example in the readme should match with the default behavior which is
that the functions convert_sum_to_gauge and convert_gauge_to_sum must be
used on the "metric" context

**Link to tracking Issue:** #34567

Maybe the Readme should state clearly in which context the functions can
be used?
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
…pen-telemetry#34580)

**Description:** promote the
`processor.transform.ConvertBetweenSumAndGaugeMetricContext` feature
flag from `alpha` to `beta`.

**Link to tracking Issue:** open-telemetry#34567

**Testing:** I modified the unit test to check when the feature flag is
enabled and disabled.

---------

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
…o_sum (open-telemetry#35022)

**Description:** The feature gate
"processor.transform.ConvertBetweenSumAndGaugeMetricContext" was updated
from Alpha to Beta. This means that it is now enabled by default. The
example in the readme should match with the default behavior which is
that the functions convert_sum_to_gauge and convert_gauge_to_sum must be
used on the "metric" context

**Link to tracking Issue:** open-telemetry#34567

Maybe the Readme should state clearly in which context the functions can
be used?
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 5, 2024
@TylerHelmuth TylerHelmuth removed the Stale label Nov 5, 2024
michael-burt pushed a commit to michael-burt/opentelemetry-collector-contrib that referenced this issue Nov 7, 2024
…ntext` as stable (open-telemetry#36216)

#### Description

Set the `processor.transform.ConvertBetweenSumAndGaugeMetricContext`
feature gate as stable

#### Link to tracking issue
Fixes
open-telemetry#34567

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
…ntext` as stable (open-telemetry#36216)

#### Description

Set the `processor.transform.ConvertBetweenSumAndGaugeMetricContext`
feature gate as stable

#### Link to tracking issue
Fixes
open-telemetry#34567

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/transform Transform processor
Projects
None yet
4 participants