Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Span Kind string values to match collector's current values #34588

Closed
awangc opened this issue Aug 9, 2024 · 3 comments · Fixed by #34472
Closed

Update Span Kind string values to match collector's current values #34588

awangc opened this issue Aug 9, 2024 · 3 comments · Fixed by #34472
Labels
enhancement New feature or request exporter/elasticsearch

Comments

@awangc
Copy link

awangc commented Aug 9, 2024 •
edited
Loading

Component(s)

exporter/elasticsearch

Describe the issue you're reporting

Currently elasticsearch exporter is encoding a span's kind using string values that do not match opentelemetry-collector's updated values (open-telemetry/opentelemetry-collector#6250) and which have been deprecated according to https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/pkg/ottl/contexts/ottlspan

It'd be great if we could have updated matching string values for kind
@awangc awangc added the needs triage New item requiring triage label Aug 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@carsonip
Copy link
Contributor

As I've responded in #34590 that this is currently being implemented in #34472 for OTel mapping mode. To take advantage of the change after #34472 is merged, you'll have to use the new, in-development, OTel mapping mode.

@carsonip carsonip mentioned this issue Aug 12, 2024
Merged
@crobert-1
Copy link
Member

Removing needs triage based on response from code owner.

@crobert-1 crobert-1 added enhancement New feature or request and removed needs triage New item requiring triage labels Aug 12, 2024
@github-actions github-actions bot mentioned this issue Aug 13, 2024
Closed
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
@carsonip @f7o
[exporter/elasticsearch] Add OTel mapping mode for traces (open-telem…
ac3e6ff 
…etry#34472)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Add OTel mapping mode for traces.

OTel mapping mode is a new mapping mode described in
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/elasticsearchexporter#elasticsearch-document-mapping

Update logs and metrics OTel mapping mode to always emit "scope" and
zero int, but not emit empty strings for known fields.

Breaking change to remove `trace_flags` from logs.

**Link to tracking Issue:** <Issue number if applicable>
Fixes open-telemetry#34588 open-telemetry#34590 

**Testing:** <Describe what testing was performed and which tests were
added.>
Added exporter tests

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request exporter/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[exporter/elasticsearch] Add OTel mapping mode for traces carsonip/opentelemetry-collector-contrib
3 participants
@awangc @carsonip @crobert-1