Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making getDimensionValue in spanmetrics and getDimensionValue in exceptionsconnector as a tool function and move to intrenal pkg #34627

Closed
JaredTan95 opened this issue Aug 13, 2024 · 2 comments
Closed

making getDimensionValue in spanmetrics and getDimensionValue in exceptionsconnector as a tool function and move to intrenal pkg #34627

JaredTan95 opened this issue Aug 13, 2024 · 2 comments
Assignees
@JaredTan95
Labels
connector/exceptions connector/spanmetrics enhancement New feature or request

Comments

@JaredTan95
Copy link
Member 

          > @jpkrohling @marctc How about making `getDimensionValue` in spanmetrics and `getDimensionValue` in exceptionsconnector as a tool function and move to `intrenal` pkg?

makes sense! maybe you could open a github issue to track it

Originally posted by @marctc in #34604 (comment)
@JaredTan95 JaredTan95 self-assigned this Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for connector/exceptions: @jpkrohling @marctc. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for connector/spanmetrics: @portertech @Frapschen. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot mentioned this issue Aug 20, 2024
Closed
@JaredTan95 JaredTan95 mentioned this issue Aug 28, 2024
Merged
jpkrohling pushed a commit that referenced this issue Sep 6, 2024
@JaredTan95
[connector/servicegraph] Extract the getDimensionValue function as …
d5595bb 
…a common function. (#34908)

**Description:** refactoring getDimensionValue func as util func for
spanmetricsconnector,servicegraphconnector,exceptionconnector common
usage
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** #34627

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
@JaredTan95 @f7o
[connector/servicegraph] Extract the getDimensionValue function as …
a4d555a 
…a common function. (open-telemetry#34908)

**Description:** refactoring getDimensionValue func as util func for
spanmetricsconnector,servicegraphconnector,exceptionconnector common
usage
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** open-telemetry#34627

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaredTan95 JaredTan95

Labels
connector/exceptions connector/spanmetrics enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JaredTan95