Release notes of 0.109.0 has incorrect feature gate for spanmetrics #35766
Labels
Comments
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
I have gone ahead and edited the release notes, thank you for your report. Please consider opening a PR to update CHANGELOG.md. |
|
Hi @atoulme, thank you for changing the release notes. |
MovieStoreGuy
pushed a commit
that referenced
this issue
Nov 10, 2024
#35852) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The wrong feature gate was exposed in the CHANGELOG, this has been corrected to the correct feature gate 'connector.spanmetrics.legacyMetricNames' <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #35766 <!--Describe the documentation added.--> #### Documentation CHANGELOG.md is updated to have the correct feature gate name. <!--Please delete paragraphs that you did not use before submitting.-->
pull bot
pushed a commit
to abaguas/opentelemetry-collector-contrib
that referenced
this issue
Nov 11, 2024
open-telemetry#35852) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The wrong feature gate was exposed in the CHANGELOG, this has been corrected to the correct feature gate 'connector.spanmetrics.legacyMetricNames' <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#35766 <!--Describe the documentation added.--> #### Documentation CHANGELOG.md is updated to have the correct feature gate name. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
connector/spanmetrics
Describe the issue you're reporting
The v0.109.0 release notes on page https://github.com/open-telemetry/opentelemetry-collector-contrib/releases talks about:
Steps to reproduce
Dockerfile with Otelcollector built together with spanmetrics. Final line of Dockerfile:
CMD ["/otelcol-custom", "--config=/etc/otel-collector-config.yml", "--feature-gates=connector.spanmetrics.legacyLatencyMetricNames" ]Build docker image
Run docker image
Expected result
Running instance of the otelcollector
Actual result
Error: invalid argument "connector.spanmetrics.legacyLatencyMetricNames" for "--feature-gates" flag: no such feature gate "connector.spanmetrics.legacyLatencyMetricNames". valid gates: [component.UseLocalHostAsDefaultHost connector.spanmetrics.legacyMetricNames processor.tailsamplingprocessor.metricstatcountspanssampled service.noopTracerProvider telemetry.disableHighCardinalityMetrics telemetry.useOtelWithSDKConfigurationForInternalTelemetry]Proposed change
Since the software is already released with the feature gate connector.spanmetrics.legacyMetricNames, I propose to change the Release notes of v0.109.0 to mention the correct feature gate.
The text was updated successfully, but these errors were encountered: