Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supervisor: configurable opamp listener port range #36001

Closed
cforce opened this issue Oct 25, 2024 · 4 comments · Fixed by #36002
Closed

supervisor: configurable opamp listener port range #36001

cforce opened this issue Oct 25, 2024 · 4 comments · Fixed by #36002
Labels
cmd/opampsupervisor enhancement New feature or request needs triage New item requiring triage

Comments

@cforce
Copy link

cforce commented Oct 25, 2024

Component(s)

cmd/opampsupervisor

Is your feature request related to a problem? Please describe.

In restricted environments with perimeter security, the firewall is preconfigured to allow specific ports or port ranges for designated users or processes. In this setup, it is essential that a service cannot choose ports on its own.

Instead, the configuration must be predetermined and statically assigned to the supervisor, with a dedicated network interface managing these settings.

Describe the solution you'd like

Configure the network interface and port range on which the opamp server will listen and setup the opamp cfg to connect to which is used by the collector.

Describe alternatives you've considered

No response

Additional context

No response

@cforce cforce added enhancement New feature or request needs triage New item requiring triage labels Oct 25, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dpaasman00
Copy link
Contributor

dpaasman00 commented Oct 25, 2024

I can take this on! I'll add a new parameter to the agent section of the supervisor config called opamp_server_port.

@dpaasman00
Copy link
Contributor

This would run the supervisor's OpAMP server on localhost:<opamp_server_port>. Would this resolve your issue, or is there a use case to not use localhost?

@cforce
Copy link
Author

cforce commented Oct 25, 2024

It would be great if you can add the port . 👍
Ii will check next week if localhost is ok or a dedicated ip is needed. I assume as long not 0.0.0.0 (all) is used i think its fine, but i will check,

djaglowski pushed a commit that referenced this issue Oct 31, 2024
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Allows the Supervisor's OpAmp server port to be configurable. This is
useful for restricted environments deploying the supervisor.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes #36001 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Updated tests and added an e2e test

<!--Describe the documentation added.-->
#### Documentation
Spec was updated accordingly. Also added documentation for previously
added `health_check_port` that wasn't present in spec.

<!--Please delete paragraphs that you did not use before submitting.-->
ArthurSens pushed a commit to ArthurSens/opentelemetry-collector-contrib that referenced this issue Nov 4, 2024
…n-telemetry#36002)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Allows the Supervisor's OpAmp server port to be configurable. This is
useful for restricted environments deploying the supervisor.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36001 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Updated tests and added an e2e test

<!--Describe the documentation added.-->
#### Documentation
Spec was updated accordingly. Also added documentation for previously
added `health_check_port` that wasn't present in spec.

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor enhancement New feature or request needs triage New item requiring triage
Projects
None yet
2 participants