Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/vcenter] Additional two metrics for vCenter receiver #37257

Closed
samiura opened this issue Jan 15, 2025 · 3 comments
Closed

[receiver/vcenter] Additional two metrics for vCenter receiver #37257

samiura opened this issue Jan 15, 2025 · 3 comments
Labels
enhancement New feature or request needs triage New item requiring triage receiver/vcenter

Comments

@samiura
Copy link
Contributor

samiura commented Jan 15, 2025

Component(s)

receiver/vcenter

Describe the issue you're reporting

There are various metrics that we don't currently capture or could capture at a higher level as mentioned on this issue before.

Adding these two additional metrics to the Vcenter receiver and by default they are disabled. These two seem to be useful for monitoring any Vcenter/ESXi server.

  1. vcenter.host.cpu.capacity
  2. vcenter.vm.memory.granted
@samiura samiura added the needs triage New item requiring triage label Jan 15, 2025
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@samiura
Copy link
Contributor Author

samiura commented Jan 15, 2025

Already I have an PR ready for this issue #37253

Copy link
Contributor

Pinging code owners for receiver/vcenter: @schmikei @StefanKurek. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

@crobert-1 crobert-1 added the enhancement New feature or request label Jan 16, 2025
songy23 pushed a commit that referenced this issue Jan 18, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds the vcenter.vm.memory.granted and vcenter.host.cpu.capacity
metric.
More information on this metric can be found
[here](https://docs.vmware.com/en/vRealize-Operations/8.10/com.vmware.vcom.metrics.doc/GUID-41603CD6-453B-4E26-A237-34E733BAB00C.html).

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#37257 


<!--Describe what testing was performed and which tests were added.-->
#### Testing
The metric was scraped from a test vCenter environment, and golden test
files were updated to reflect the addition of the metric.


<!--Describe the documentation added.-->
#### Documentation
Documentation was updated according to the metadata.yaml


<!--Please delete paragraphs that you did not use before submitting.-->

<img width="959" alt="Screenshot 2025-01-14 at 10 48 02 AM"
src="https://github.com/user-attachments/assets/7c88902f-fe21-4c7d-be17-ba79a92222f3"
/>

<img width="919" alt="Screenshot 2025-01-15 at 11 35 31 AM"
src="https://github.com/user-attachments/assets/77e19e19-93e4-410a-b501-6477c77e78da"
/>

Co-authored-by: Antoine Toulme <antoine@toulme.name>
@samiura samiura closed this as completed Jan 18, 2025
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds the vcenter.vm.memory.granted and vcenter.host.cpu.capacity
metric.
More information on this metric can be found
[here](https://docs.vmware.com/en/vRealize-Operations/8.10/com.vmware.vcom.metrics.doc/GUID-41603CD6-453B-4E26-A237-34E733BAB00C.html).

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
open-telemetry#37257 


<!--Describe what testing was performed and which tests were added.-->
#### Testing
The metric was scraped from a test vCenter environment, and golden test
files were updated to reflect the addition of the metric.


<!--Describe the documentation added.-->
#### Documentation
Documentation was updated according to the metadata.yaml


<!--Please delete paragraphs that you did not use before submitting.-->

<img width="959" alt="Screenshot 2025-01-14 at 10 48 02 AM"
src="https://github.com/user-attachments/assets/7c88902f-fe21-4c7d-be17-ba79a92222f3"
/>

<img width="919" alt="Screenshot 2025-01-15 at 11 35 31 AM"
src="https://github.com/user-attachments/assets/77e19e19-93e4-410a-b501-6477c77e78da"
/>

Co-authored-by: Antoine Toulme <antoine@toulme.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/vcenter
Projects
None yet
Development

No branches or pull requests

2 participants