Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/mysq] Capture deletes and update across multiple tables #37301

Closed
atoulme opened this issue Jan 18, 2025 · 3 comments · Fixed by #37329
Closed

[receiver/mysq] Capture deletes and update across multiple tables #37301

atoulme opened this issue Jan 18, 2025 · 3 comments · Fixed by #37329
Assignees
Labels
enhancement New feature or request receiver/mysql

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 18, 2025

Component(s)

No response

Is your feature request related to a problem? Please describe.

https://dev.mysql.com/doc/refman/8.4/en/server-status-variables.html reports:

Com_xxx

The Com_xxx statement counter variables indicate the number of times each xxx statement has been executed. There is one status variable for each type of statement. For example, Com_delete and Com_update count DELETE and UPDATE statements, respectively. Com_delete_multi and Com_update_multi are similar but apply to DELETE and UPDATE statements that use multiple-table syntax.

We do not currently track Com_delete_multi and Com_update_multi in the code.

Describe the solution you'd like

Add watching Com_delete_multi and Com_update_multi

Describe alternatives you've considered

No response

Additional context

No response

@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage receiver/mysql and removed needs triage New item requiring triage labels Jan 18, 2025
Copy link
Contributor

Pinging code owners for receiver/mysql: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

@CodePrometheus
Copy link
Contributor

@atoulme @djaglowski hello all, could I pull a request to help with adding these metrics?

@atoulme
Copy link
Contributor Author

atoulme commented Jan 18, 2025

I can assign the issue to you and you can work on it, just bear in mind @djaglowski has final word as the codeowner of the component, but I don't think this is a controversial issue and we are always happy to have help. Thank you!

djaglowski pushed a commit that referenced this issue Jan 21, 2025
…ric (#37329)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes #37301

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
…ric (open-telemetry#37329)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#37301

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/mysql
Projects
None yet
2 participants