Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-collector-module-version.sh failed on macos if using gnu-sed #37304

Closed
zirain opened this issue Jan 18, 2025 · 0 comments · Fixed by #37306
Closed

check-collector-module-version.sh failed on macos if using gnu-sed #37304

zirain opened this issue Jan 18, 2025 · 0 comments · Fixed by #37306
Labels
needs triage New item requiring triage

Comments

@zirain
Copy link
Contributor

zirain commented Jan 18, 2025

Component(s)

No response

Describe the issue you're reporting

.github/workflows/scripts/check-collector-module-version.sh 
Checking go.opentelemetry.io/collector is used with v0.117.1-0.20250117002813-e970f8bb1258
sed: can't read s|go.opentelemetry.io/collector [^ ]*|go.opentelemetry.io/collector v0.117.1-0.20250117002813-e970f8bb1258|g: No such file or directory
@zirain zirain added the needs triage New item requiring triage label Jan 18, 2025
@zirain zirain mentioned this issue Jan 18, 2025
Merged
@github-actions github-actions bot mentioned this issue Jan 21, 2025
Open
MovieStoreGuy added a commit that referenced this issue Jan 22, 2025
@zirain @MovieStoreGuy
[chore] detect gnu-sed (#37306)
8034e0d 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

make `check-collector-module-version.sh` worked on macos with gnu-sed.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
#37304

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
@zirain @MovieStoreGuy @chengchuanpeng
[chore] detect gnu-sed (open-telemetry#37306)
bb19c15 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

make `check-collector-module-version.sh` worked on macos with gnu-sed.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
open-telemetry#37304

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] detect gnu-sed zirain/opentelemetry-collector-contrib
1 participant
@zirain