Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidcauthextension - do not verify issuer and issuer_url match #37780

Open
hwrdthdck opened this issue Feb 7, 2025 · 4 comments
Open

oidcauthextension - do not verify issuer and issuer_url match #37780

hwrdthdck opened this issue Feb 7, 2025 · 4 comments
Labels
enhancement New feature or request extension/oidcauth needs triage New item requiring triage

Comments

@hwrdthdck
Copy link

hwrdthdck commented Feb 7, 2025

Component(s)

extension/oidcauth

Is your feature request related to a problem? Please describe.

I work in environments where the issuer_url string does not match the issue value in the well-known configuration file. The example below shows how the WebURL uses the fqdn but the issuer configured at the time uses the hostname. Currently, oidcauthextension requires both values to match in order to work. I am requesting that the dependency for both values to match be removed.

WebURL: https://myidentity.domain.com

"issuer": "myidentity",
"jwks_uri": "https://myidentity.domain.com/api/jwks",
"token_endpoint": "https://myidentity.domain.com/api/OAuth/Token",
"grant_types_supported": [
"client_credentials"
],
"token_endpoint_auth_methods_supported": [
"client_secret_basic",
"client_secret_post"
],
"id_token_signing_alg_values_supported": [
"RS256"
]

Describe the solution you'd like

Add an exception to ignore whether or not Issuer and issue_url match.

An example would be:

ignore_issuer_match: true

Describe alternatives you've considered

As shown in the Additional Context field, allow verification to be based on fqdn or hostname, remove the protocol (https://) from the verification.

Additional context

Error: failed to start extensions: failed to get configuration from the auth server: oidc: issuer did not match the issuer returned by provider, expected "https://MySecurity" got "MySecurity"

@hwrdthdck hwrdthdck added enhancement New feature or request needs triage New item requiring triage labels Feb 7, 2025
@hwrdthdck hwrdthdck changed the title oidcauthextension - do not verify issuer and issue_url match oidcauthextension - do not verify issuer and issuer_url match Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling
Copy link
Member

Duplicate of #36568.

@hwrdthdck
Copy link
Author

hwrdthdck commented Feb 8, 2025 via email

@hwrdthdck
Copy link
Author

Component

Duplicate of #36568.

#37780 is not asking for the same exception as #36568; I am asking that the check to verify issuer and issuer_url match have an option to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension/oidcauth needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

2 participants