Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released MSIs have version 0.0.1 since v0.39.0 #6925

Closed
bkabrda opened this issue Dec 21, 2021 · 5 comments
Closed

Released MSIs have version 0.0.1 since v0.39.0 #6925

bkabrda opened this issue Dec 21, 2021 · 5 comments
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues os:windows

Comments

@bkabrda
Copy link

bkabrda commented Dec 21, 2021

Describe the bug
It seems that since v0.39.0, the MSIs attached to the releases have version 0.0.1, see e.g. https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.39.0 - otel-contrib-collector-0.0.1-amd64.msi.

Steps to reproduce
Go to https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.39.0

What did you expect to see?
otel-contrib-collector-0.39.0-amd64.msi

What did you see instead?
otel-contrib-collector-0.0.1-amd64.msi

What version did you use?
v0.39.0

What config did you use?
N/A

Environment
N/A

Additional context
N/A

@bkabrda bkabrda added the bug Something isn't working label Dec 21, 2021
@jpkrohling
Copy link
Member

Is it wrong only in the file name? In any case, we are moving the building of the assets to the -releases repository. The bad news is that MSI builds are not part of it yet.

@alolita, you mentioned earlier this year that you might have people available to help with that? I don't have the skills or the resources to work on MSI packages.

@jpkrohling jpkrohling added ci-cd CI, CD, testing, build issues os:windows labels Dec 21, 2021
@bkabrda
Copy link
Author

bkabrda commented Dec 21, 2021

Yeah, I think the problem really is just the filename.

@jpkrohling jpkrohling self-assigned this Dec 21, 2021
@jpkrohling
Copy link
Member

I'll assign this to myself to work on fixing the file name, but it's possible that we'll just not have an MSI package for 0.42.0 anymore until someone helps by adding support for it at the -releases repo.

@jpkrohling jpkrohling removed their assignment Aug 23, 2022
@jpkrohling
Copy link
Member

I'm unassigning this from me, as I do not have the intention or resources to work on this.

@evan-bradley
Copy link
Contributor

The Collector releases repo now handles building all executables and releasing an MSI installer is covered there by this issue: open-telemetry/opentelemetry-collector-releases#157. I'm closing this issue in favor of that one.

animetauren pushed a commit to animetauren/opentelemetry-collector-contrib that referenced this issue Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues os:windows
Projects
None yet
Development

No branches or pull requests

3 participants