Migrate to Go1.13 #104
Merged
Migrate to Go1.13 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been building core, contrib and some internal collectors with 1.13 for quite some time now and have resolved all issues that came with the upgrade already. This should be a very safe change. This will allow us to use leverage new features and fixes shipped by 1.13 such as updates to Go modules, error wrapping, etc.
owais
requested review from
bogdandrutu,
flands,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
owais
changed the title
tigrannajaryan
approved these changes
Jan 20, 2020
|
Note, master build failed after merging this PR: https://circleci.com/gh/open-telemetry/opentelemetry-collector-contrib/360 |
bogdandrutu
added a commit
that referenced
this pull request
May 12, 2022
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Move instrumentation fastapi
vastin
pushed a commit
to vastin/opentelemetry-collector-contrib
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been building core, contrib and some internal collectors with 1.13
for quite some time now and have resolved all issues that came with the
upgrade already. This should be a very safe change.
This will allow us to use leverage new features and fixes shipped by
1.13 such as updates to Go modules, error wrapping, etc.