-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s Processor: logs support #1051
K8s Processor: logs support #1051
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
+ Coverage 88.81% 88.83% +0.01%
==========================================
Files 250 250
Lines 11924 11945 +21
==========================================
+ Hits 10590 10611 +21
Misses 990 990
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
While working on this PR I noticed two things:
Let me know what do you think, those should be quick to add if they make sense |
Using README is more consistent
Sounds like a good idea |
Description: Adds log support to
k8sprocessor
Link to tracking Issue: open-telemetry/opentelemetry-collector#1654
Testing: unit tests cover logs use-cases, manual tests via fluentforward protocol done (and spans to confirm nothing breaks)
Documentation: updated
doc.go
and cleared-out (hopefully) how is the pod IP address determined