-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the tests seem to expect UTZ #1076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I tested it locally and it fixes the tests. The failing CI seems to be a transient failure.
Codecov Report
@@ Coverage Diff @@
## master #1076 +/- ##
=======================================
Coverage 88.81% 88.81%
=======================================
Files 250 250
Lines 11924 11924
=======================================
Hits 10590 10590
- Misses 990 991 +1
+ Partials 344 343 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/CC @lizthegrey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeitlinger thanks you for fixing.
Description:
The tests were failing while running locally.
The time zone of
opencensus.start_timestamp
was the local time+02:00
instead ofZ
.