Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the tests seem to expect UTZ #1076

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

zeitlinger
Copy link
Member

Description:

The tests were failing while running locally.
The time zone of opencensus.start_timestamp was the local time +02:00 instead of Z.

@zeitlinger zeitlinger requested a review from a team September 21, 2020 07:06
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I tested it locally and it fixes the tests. The failing CI seems to be a transient failure.

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1076 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1076   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files         250      250           
  Lines       11924    11924           
=======================================
  Hits        10590    10590           
- Misses        990      991    +1     
+ Partials      344      343    -1     
Flag Coverage Δ
#integration 75.52% <ø> (+0.10%) ⬆️
#unit 87.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/honeycombexporter/translator.go 86.88% <100.00%> (ø)
...eiver/awsxrayreceiver/internal/udppoller/poller.go 97.61% <0.00%> (-2.39%) ⬇️
receiver/k8sclusterreceiver/watcher.go 97.64% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff19a2...e4223c7. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeitlinger thanks you for fixing.

@tigrannajaryan tigrannajaryan merged commit 097fc62 into open-telemetry:master Sep 22, 2020
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants