Add Datadog exporter overall structure #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 99129fb96e29e9c1a92da00b7e3f8efcae8a31e8
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Sep 3 18:10:28 2020 +0200
Handle namespace at initialization time
commit babca25927926a60c0c416294af3aadf784d41b9
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Sep 3 17:23:53 2020 +0200
Initialize on a separate function
This way the variables can be checked without worrying about the env
commit 24d0cb4cc566fa5313a8650c904a27bea68bf555
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Sep 3 14:30:35 2020 +0200
Check environment variables for unified service tagging
commit 6695f8297ab8b1fcae71b05acb027c4a0992e3a0
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Wed Sep 2 14:57:37 2020 +0200
Add support for sending metrics through the API
- Use datadog.Metric type for simplicity
- Get host if unset
commit c366603
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Wed Sep 2 09:56:24 2020 +0200
Disable Queue and Retry settings (#72)
These are handled by the statsd package.
OpenTelemetry docs are confusing and the default configuration (disabled)
is different from the one returned by "GetDefault..." functions
commit a660b56
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Tue Sep 1 15:26:14 2020 +0200
Add support for summary and distribution metric types (#65)
* Add support for summary metric type
* Add support for distribution metrics
* Refactor metrics construction
- Drop name in Metrics (now they act as Metric values)
- Refactor constructor so that errors happen at compile-time
* Report Summary total sum and count values
Snapshot values are not filled in by OpenTelemetry
* Report p00 and p100 as `.min` and `.max`
This is more similar to what we do for our own non-additive type
* Keep hostname if it has not been overridden
commit c95adc4
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Aug 27 13:00:02 2020 +0200
Update dependencies and `make gofmt`
The collector was updated to 0.9.0 upstream
commit 20afb0e
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Wed Aug 26 18:25:49 2020 +0200
Refactor configuration (#45)
* Refactor configuration
* Implement telemetry and tags configuration handling
* Update example configuration and README file
Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com>
commit fdc98b5
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Fri Aug 21 11:09:08 2020 +0200
Initial DogStatsD implementation (#15)
Initial metrics exporter through DogStatsD with support for all metric types but summary and distribution
commit e848a60
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Fri Aug 21 10:42:45 2020 +0200
Bump collector version
commit 58be9a4
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Thu Aug 6 10:04:32 2020 +0200
Address linter
commit 695430c
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Tue Aug 4 13:28:01 2020 +0200
Fix field name error
MetricsEndpoint was renamed to MetricsURL
commit 168b319
Author: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Date: Mon Aug 3 11:05:01 2020 +0200
Create initial outline for Datadog exporter (#1)
* Add support for basic configuration options
* Documents configuration options
* Backport changes from upstream PR Remove `err` from MapMetrics * Remove usage of pdatautil * Fix tests * Use TCPAddr * Review which functions should be private
* Remove DogStatsD mode * go mod tidy * Remove mentions to DogStatSD
* Improve test coverage Added unit tests for - API key censoring - Hostname - Metrics exporter Renamed test and implementation files for consistency * Add one additional test
The zorkian API does not validate the API key unless you also have an application key, even though the endpoint works without it. I am removing this validation until this gets fixed on the zorkian library
Following the contribution guidelines we need to make a first PR with this
It is not being used as of now until the OTLP metrics format stabilizes and we have a Summary type metric again
The API key is now a required setting
Codecov Report
@@ Coverage Diff @@
## master #1142 +/- ##
==========================================
+ Coverage 89.89% 89.91% +0.01%
==========================================
Files 276 278 +2
Lines 13621 13667 +46
==========================================
+ Hits 12244 12288 +44
- Misses 1011 1012 +1
- Partials 366 367 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
julien-lebot
approved these changes
Sep 28, 2020
|
Approving on behalf of Datadog |
bogdandrutu
reviewed
Sep 28, 2020
tigrannajaryan
approved these changes
Sep 29, 2020
|
Please resolve the conflict. |
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
One example with the minimal configuration, for sending to `datadoghq.com` and a second one for sending to `datadoghq.eu`
|
@tigrannajaryan I addressed the last comments and resolved the conflict. |
6 tasks
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
This is a breaking OTLP change. - Use AnyValue introduced in recent change to OTLP. Changes are encapsulated in AttributeValue and most of the codebase is unaffected, which proves the wrappers are very useful. - Rename AttributeKeyValue to KeyValue (the change comes from OTLP). - Use local protoc to compile ProtoBufs. Previously used znly/protoc docker image is outdated and results in incorrect code for gRPC-Gateway. TODO: - Need to add support for ARRAY value type. This is not urgent since there are no known data sources that use the ARRAY type yet. - Use Gogoproto `(gogoproto.nullable) = false` annotation for AnyValue to possibly improve performance further.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Rename 'correlation' to 'baggage' * Rename CorrelationContext progator to Baggage * Update CHANGELOG
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add Datadog exporter overall structure following the contributing guidelines.
This is a rework of #900: instead of using
statsdit will report directly to Datadog's backend. It incorporates the feedback from that PR's reviews.Link to tracking Issue: n/a
Testing: Added unit tests, tested full version (available on our fork) on an end to end testing environment.
Documentation: This adds the README for the exporter with the intended instructions for the full metrics exporter.
Note: The commit numbering refers to the PRs on our fork but are shown incorrectly by Github.