adding filtering based on span kinds #13612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-shopify
force-pushed
the
match_span_kind
branch
2 times, most recently
from
daa437e to
a71b36d
Compare
|
@mx-psi pining for review :) |
arun-shopify
force-pushed
the
match_span_kind
branch
from
0523ba0 to
5e45fd9
Compare
arun-shopify
requested review from
djaglowski,
dashpole,
jmacd,
dmitryax and
Aneurysm9
as code owners
arun-shopify
requested review from
jpkrohling,
mx-psi,
bogdandrutu,
jsuereth,
punya and
arminru
as code owners
arun-shopify
force-pushed
the
match_span_kind
branch
from
3e419dc to
a83dc3f
Compare
|
@mx-psi ping for review :) appreciate it. |
|
@arun-shopify Hey, I just got back from a long PTO and have a long queue of PRs to review so it may take a few days for me to get back, but rest assured that I will get down to it eventually :) |
no worries! thanks for letting me know, just wanted to make sure this PR was in your radar :) |
mx-psi
reviewed
Sep 9, 2022
|
Github did not run the tests, do you mind pushing an empty commit? |
mx-psi
reviewed
Sep 16, 2022
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
arun-shopify
force-pushed
the
match_span_kind
branch
from
2620312 to
69e1f65
Compare
mx-psi
approved these changes
Sep 19, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
Sep 19, 2022
…pan kinds (open-telemetry#13612) * adding filtering based on span kinds * fixed tests * unreleased yaml * span kind validation * Update internal/coreinternal/processor/filterconfig/config.go Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * added test for spankind config validation * added comment Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature that enables filtering spans based on
span_kind.Testing:
Unit tests added to test span kind filtering.