[receiver/hostmetrics] Add optional metric process.cpu.utilization
#14539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Sep 27, 2022
receiver/hostmetricsreceiver/internal/scraper/processscraper/metadata.yaml
Outdated
Show resolved
Hide resolved
andrzej-stencel
force-pushed
the
add-process-cpu-utilization-metric
branch
2 times, most recently
from
c0c00f4
to
89deabe
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
andrzej-stencel
force-pushed
the
add-process-cpu-utilization-metric
branch
4 times, most recently
from
1c72e86
to
f91464e
Compare
TylerHelmuth
approved these changes
Oct 19, 2022
andrzej-stencel
force-pushed
the
add-process-cpu-utilization-metric
branch
from
17075dc
to
0a4a3f5
Compare
dmitryax
reviewed
Oct 21, 2022
receiver/hostmetricsreceiver/internal/scraper/processscraper/documentation.md
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processscraper/ucal/cpu_utilization_calculator.go
Show resolved
Hide resolved
|
and PTAL at failing test |
andrzej-stencel
force-pushed
the
add-process-cpu-utilization-metric
branch
2 times, most recently
from
0e4d22e
to
4856f29
Compare
|
Thank you @dmitryax for the review comments 🙏 keep them coming 🙂 |
andrzej-stencel
force-pushed
the
add-process-cpu-utilization-metric
branch
from
205c4fa
to
487d87a
Compare
andrzej-stencel
force-pushed
the
add-process-cpu-utilization-metric
branch
from
487d87a
to
24f370c
Compare
andrzej-stencel
force-pushed
the
add-process-cpu-utilization-metric
branch
from
24f370c
to
cb43ed1
Compare
|
Rebased again. Not sure why the exporter tests failed on Windows, I don't think it's related to this change. @dmitryax can this be merged? |
dmitryax
approved these changes
Nov 29, 2022
|
@astencel-sumo I did some changes to the mdatagen tool. Can you please rebase and run |
This metric is described in [semantic conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.13.0/specification/metrics/semantic_conventions/process-metrics.md), but hasn't been exposed until now. This metric has an equivalent in Telegraf as `procstat.cpu_usage`.
andrzej-stencel
force-pushed
the
add-process-cpu-utilization-metric
branch
from
cb43ed1
to
ab624d5
Compare
Done 👍 |
andrzej-stencel
changed the title
process.cpu.utilization metricprocess.cpu.utilization
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…pen-telemetry#14539) [receiver/hostmetrics] Add `process.cpu.utilization` metric This metric is described in [semantic conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.13.0/specification/metrics/semantic_conventions/process-metrics.md), but hasn't been exposed until now. This metric has an equivalent in Telegraf as `procstat.cpu_usage`.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds an optional metric named
process.cpu.utilization, as described in the semantic conventions, to the metrics scraped by theprocessscraper of thehostmetricsreceiver.Link to tracking Issue:
#14084
Context:
This metric has an equivalent in Telegraf as
procstat.cpu_usage.