Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/elasticsearch]: add document count metrics on index level #14874

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

aboguszewski-sumo
Copy link
Member

Description:
Metrics relating to document count on index level have been added:

elasticsearch_indices_stats_primaries_docs_count
elasticsearch_indices_stats_total_docs_count

Link to tracking Issue: #14635

Testing:
Tests will be fixes once the metric schema gets accepted.

Documentation:
mdatagen

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 26, 2022
@aboguszewski-sumo
Copy link
Member Author

@djaglowski this PR got marked as stale, could you review it soon?

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data model and implementation looks good.

receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
@aboguszewski-sumo
Copy link
Member Author

Rebased.

@aboguszewski-sumo
Copy link
Member Author

@djaglowski I rebased it again and the workflow passed, I think it can be merged now.

@djaglowski djaglowski merged commit f67ff81 into open-telemetry:main Nov 17, 2022
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants