Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[awsemfexporter] Implement metric filtering and dimension setting #1503

Merged
merged 8 commits into from
Nov 13, 2020
Merged

[awsemfexporter] Implement metric filtering and dimension setting #1503

merged 8 commits into from
Nov 13, 2020

Commits on Nov 12, 2020

  1. Create MetricDeclaration struct

    @kohrapha
    kohrapha committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    06b864e View commit details
    Browse the repository at this point in the history

  2. Implement dimension dedup logic when adding rolledup dimensions (#6) 

    * Implement dimension dedup logic when adding rolledup dimensions

* Remove duplicated dimensions in metric declaration
    @kohrapha
    kohrapha committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    0c4c858 View commit details
    Browse the repository at this point in the history

  3. Create benchmark for filtering with metric declarations and use asser… 

    …tCwMeasurementEqual for tests
    @kohrapha
    kohrapha committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    86b706b View commit details
    Browse the repository at this point in the history

  4. Move helper test code to the top of file

    @kohrapha
    kohrapha committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7cc3fa6 View commit details
    Browse the repository at this point in the history

  5. Update dimRollup test

    @kohrapha
    kohrapha committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7acc4d2 View commit details
    Browse the repository at this point in the history

  6. Aggregate dimensions and perform dedup

    @kohrapha
    kohrapha committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    60f4845 View commit details
    Browse the repository at this point in the history

  7. Minor code change

    @kohrapha
    kohrapha committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    80a42c0 View commit details
    Browse the repository at this point in the history

  8. Fix test failure from merging new changes

    @kohrapha
    kohrapha committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    2c31065 View commit details
    Browse the repository at this point in the history