[exporter/prometheusremotewrite] Add timeout to prevent deadlock #15278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een writing and reading from the WAL
|
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Is there anything else I can provide to help move this along? |
|
There seems to be no traction here, closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a timeout when reading from the WAL, as it shares a lock with the process that also writes to the WAL, creating a deadlock.
Link to tracking Issue: #15277
Testing: Adding this change allows metrics to be forwarded properly