Enable resource attributes to metric label conversion option #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
|
Tagging @mxiamxia @shaochengwang @wyTrivail for visibility. |
Codecov Report
@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
+ Coverage 89.40% 89.41% +0.01%
==========================================
Files 354 354
Lines 17313 17324 +11
==========================================
+ Hits 15478 15490 +12
+ Misses 1372 1371 -1
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Nov 11, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
* Add headers in HTTPClientSettings * add helper * Revert "add helper" This reverts commit 394f94f8e1c5dae11d67166030fcb718da665862. * remove testutil_test * add interceptor only when there are headers * add documentation fix TestAllHTTPClientSettings
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Update license-check to ignore all vendor dirs * Remove vendor path exclude from license-check find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Recently a PR 2060 was merged in the core
opentelemetry-collectorrepo for converting resource attributes to metric labels. This was added as a utility option in theexporterhelpermodule so that any exporter can easily opt-in. We need to enable this settings forawsemfexporter so that customer can enable it if they want.This is a required option for AWS ECS Container Metrics customers.
This change introduces a new function for creating the
componenet.MetricsExporterwhich utilizes theexporterhelpermodule withresource_to_telemetry_conversionoption as well as our pre-existingNew()function.Link to tracking Issue:
#1551
Testing:
It passes all the existing unit tests.
Added new unit tests for testing the new changes.
Manually tested for e2e experience.
Documentation:
README updated.