[chore] Don't use result of [SpanKind|StatusCode].String as identifiers #16021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2022
dmitryax
force-pushed
the
dont-use-span-string
branch
2 times, most recently
from
5a24a22 to
5f512c2
Compare
bogdandrutu
approved these changes
Nov 2, 2022
TylerHelmuth
approved these changes
Nov 2, 2022
dmitryax
force-pushed
the
dont-use-span-string
branch
from
5f512c2 to
e71e5d1
Compare
codeboten
approved these changes
Nov 2, 2022
[SpanKind|StatusCode].String() will be changed to return different string values. This change replaces existing method calls with contrib internal functions to avoid breaking changes when open-telemetry/opentelemetry-collector#6250 is merged
dmitryax
force-pushed
the
dont-use-span-string
branch
from
e71e5d1 to
1e35f8f
Compare
dineshg13
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…rs (open-telemetry#16021) [SpanKind|StatusCode].String() will be changed to return different string values. This change replaces existing method calls with contrib internal functions to avoid breaking changes
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…rs (open-telemetry#16021) [SpanKind|StatusCode].String() will be changed to return different string values. This change replaces existing method calls with contrib internal functions to avoid breaking changes
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SpanKind|StatusCode].String() will be changed to return different string values in open-telemetry/opentelemetry-collector#6250. This change replaces existing method calls with contrib internal functions to avoid breaking changes.