Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] Rename ottllogs to ottllog #16242

Merged
merged 8 commits into from
Nov 11, 2022
Merged

[pkg/ottl] Rename ottllogs to ottllog #16242

merged 8 commits into from
Nov 11, 2022

Conversation

TylerHelmuth
Copy link
Member

Description:
Renames ottllogs to ottllog to align with singular contexts

Testing:
Unit Tests

Documentation:
Updated READMEs

@TylerHelmuth TylerHelmuth requested a review from a team November 10, 2022 17:50
@github-actions github-actions bot added pkg/ottl processor/routing Routing processor processor/transform Transform processor labels Nov 10, 2022
codeboten
codeboten reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ottllog seems hard to type, since it's already under ottl/context why not call this package log? Or would that cause too many naming conflicts?

@bogdandrutu
Copy link
Member

ottllog seems hard to type, since it's already under ottl/context why not call this package log? Or would that cause too many naming conflicts?

We prefix this everywhere, good question if we should not.

@TylerHelmuth
Copy link
Member Author

@codeboten with the way the package is structured I think if we named the package log then the default reference would be log.<something in the package> right? Users would have to do a named import every time to avoid any conflicts.

codeboten
codeboten approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the change as is, though it still seems like the ergonomics of using the package need a bit more thinking. I agree that log, span, datapoint... would likely end up with conflicts, just not sure that prefixing with ottl is the right solution

@bogdandrutu
Copy link
Member

needs rebase

@github-actions github-actions bot requested a review from kovrus November 11, 2022 14:05
@bogdandrutu bogdandrutu merged commit c10532d into open-telemetry:main Nov 11, 2022
@TylerHelmuth TylerHelmuth deleted the ottl-rename-ottllogs branch November 11, 2022 20:55
mdelapenya added a commit to mdelapenya/opentelemetry-collector-contrib that referenced this pull request Nov 15, 2022
@mdelapenya
Merge branch 'main' into receivers-testcontainers-go
6e185f4 
* main:
  [chore] dependabot updates Tue Nov 15 00:17:56 UTC 2022 (open-telemetry#16300)
  [receiver/rabbitmq] Fix flaky integration test (open-telemetry#16240)
  [Docker Stats Receiver] Add @jamesmoessis as code owner (open-telemetry#16253)
  [receiver/mongodbatlas] Alerts poll mode check hostname and port (open-telemetry#16286)
  [chore] update jaeger dep (open-telemetry#16287)
  [pkg/stanza] Fix issue where specifying a non-existent storage extension caused panic during shutdown. (open-telemetry#16213)
  [pkg/ottl] Rename ottllogs to ottllog (open-telemetry#16242)
  Register featuregate, otherwise does not work (open-telemetry#16269)
  [receiver/elasticsearch]: add fielddata memory size metrics on index level (open-telemetry#14922)
  [chore] remove what looks to be debugging code from instanaexporter (open-telemetry#16258)
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
@TylerHelmuth @JaredTan95
[pkg/ottl] Rename ottllogs to ottllog (open-telemetry#16242)
89852dd 
* Rename ottllogs to ottllog

* add changelog entry

* fix lint
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@TylerHelmuth @shalper2
[pkg/ottl] Rename ottllogs to ottllog (open-telemetry#16242)
5992e66 
* Rename ottllogs to ottllog

* add changelog entry

* fix lint
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@kovrus kovrus Awaiting requested review from kovrus

Assignees

@Aneurysm9 Aneurysm9

Labels
pkg/ottl processor/routing Routing processor processor/transform Transform processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TylerHelmuth @bogdandrutu @codeboten @kovrus @evan-bradley @Aneurysm9