[pkg/ottl] Commonize logic for handling slice and non-slice args #16298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
requested review from
TylerHelmuth and
bogdandrutu
as code owners
TylerHelmuth
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
@evan-bradley thanks for taking care of this bug. I would love so much to get rid of the need for DSLArgumentIndex someday and just ensure all functions have access to settings via some deterministic way.
TylerHelmuth
added
the
ready to merge
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…n-telemetry#16298) * Commonize logic for handling slice and non-slice args * Add PR number for issue reference Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…n-telemetry#16298) * Commonize logic for handling slice and non-slice args * Add PR number for issue reference Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I discovered while adding logging in functions that the incorrect index was being used to get the invocation argument value for slice parameters, which caused an error when a function factory had an internal type as a parameter.
This commonizes a lot of the behavior between the
buildArgandbuildSliceArgmethods and makes it so they don't have to handle indexing the invocation arguments list. Since the invocation object and argument index aren't passed to many of the functions anymore, I've also reworded some error messages to make sure a user knows the full context of an error.Testing:
Modified the existing tests to cover the internal argument case. All tests still pass.