GoogleCloudSpannerReceiver: Mask lock stats PII #16343
Conversation
changelog . Code review changes
receiver/googlecloudspannerreceiver/internal/metadata/metricsdatapoint_test.go
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/statsreader/intervalstatsreader.go
Outdated
Show resolved
Hide resolved
Even though you are addressing a customer request to Google, it is still good to open an issue describing what you are attempting to do. Leave out customer details, but the collector maintainers should be able to understand why you need the functionality. It is also a good place to list what you've tried, but doesn't meet your use-case (e.g. redaction or transform processor). |
Done. Opened issue at #16349 and linked to it in this PR's description! @dashpole PTAL at the updated PR again. Thank you! |
|
Can you ask one of the other CODEOWNERS (@ydrozhdzhal @asukhyy @khospodarysko) to review as well? |
Unfortunately they no longer work with us on this code as the contract has ended. @ydrozhdzhal @asukhyy would it be possible to have a look at the PR? Thanks! |
|
If they are no longer active as approvers, we should remove them from CODEOWNERS. I can approve this PR in that case. Are you able to nominate anyone else who would have enough context to review PRs to this component? A single active approver isn't ideal. |
Yes, I will add Varun and Kiranmayi from Google, to be a codeowner in the next PR Update : Done at #16385 |
|
@Aneurysm9 gentle reminder for review. Thank you! |
|
@varunraiko is now added as a code owner and can review instead of @Aneurysm9 |
* Hide lock stats PII changelog . Code review changes * chlog * correct merge conflicts * remove extra space * code review changes * Added another test case
Description: Cloud Spanner receiver should have the capability to mask sensitive information. This PR adds a configurable option to mask the PII in lock stats metrics for customers.
NOTE THAT THIS PR WAS ALREADY BEING REVIEWED AT #14607 BUT GOT CLOSED BECAUSE INACTIVE
For the metric "top minute lock stats", the label "row_range_start_key" (https://cloud.google.com/spanner/docs/introspection/lock-statistics#explain-row-range) has PII information of table key values. We have now given the ability to hash the keys individually such that
table_name(key1,key2) becomes table_name(hash1,hash2).
Note that even though key values are hashed, a user can identify if sets of keys share common prefix like table1(key1,key2) and table1(key1,key3)
Link to tracking Issue: #16349
Testing: Unit tests added. Manual end-to-end testing done by running the service locally and verifying the hashed row_range_start_key values.
Documentation: Added the configuration option and the corresponding info in the README