Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] Add support for setting maps in Values #16352

Merged
merged 3 commits into from
Nov 18, 2022
Merged

[pkg/ottl] Add support for setting maps in Values #16352

merged 3 commits into from
Nov 18, 2022

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Nov 17, 2022 •
edited
Loading

Description:
Adds support for setting maps in Values. The primary impact is the ability for contexts to set maps as attribute values.

Link to tracking Issue:
Closes #16337

Testing:
Added unit tests

@TylerHelmuth TylerHelmuth requested review from djaglowski and a team November 17, 2022 18:43
@TylerHelmuth TylerHelmuth mentioned this pull request Nov 17, 2022
Closed
evan-bradley
evan-bradley approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One thing I think we should also support are maps with typed values, but that doesn't block this PR.

pkg/ottl/contexts/internal/ottlcommon/value.go Show resolved Hide resolved
kentquirk
kentquirk approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much support this, and I think it should be merged before #16340.

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Nov 18, 2022
@codeboten codeboten merged commit 303f19e into open-telemetry:main Nov 18, 2022
@TylerHelmuth TylerHelmuth deleted the ottl-handle-maps branch November 18, 2022 18:52
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
@TylerHelmuth @JaredTan95
[pkg/ottl] Add support for setting maps in Values (open-telemetry#16352)
8eddf9e 
 Adds support for setting maps in Values. The primary impact is the ability for contexts to set maps as attribute values.
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@TylerHelmuth @shalper2
[pkg/ottl] Add support for setting maps in Values (open-telemetry#16352)
de131b0 
 Adds support for setting maps in Values. The primary impact is the ability for contexts to set maps as attribute values.
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@kentquirk kentquirk kentquirk approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

Assignees

@jpkrohling jpkrohling

Labels
pkg/ottl ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pkg/ottl] Update contexts to properly handle map values in attributes
5 participants
@TylerHelmuth @kentquirk @evan-bradley @jpkrohling @codeboten